fix: log toolbox tool results with the correct metadata#1406
Open
atharvasingh7007 wants to merge 1 commit intosimonw:mainfrom
Open
fix: log toolbox tool results with the correct metadata#1406atharvasingh7007 wants to merge 1 commit intosimonw:mainfrom
atharvasingh7007 wants to merge 1 commit intosimonw:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix toolbox-backed tool-result logging so each result uses its own tool metadata
update the mixed-toolbox logging regression to assert Memory results stay attributed to Memory
Root cause
_BaseResponse.log_to_db() reused the ool loop variable from the earlier or tool in self.prompt.tools loop when inserting ool_instances rows for self.prompt.tool_results. In Python that leaked the last tool from the previous loop, so mixed toolbox runs logged every result against the last toolbox.
Testing
C:\Users\Atharva\Documents\CODEX\llm.venv\Scripts\python.exe -m pytest tests/test_plugins.py
C:\Users\Atharva\Documents\CODEX\llm.venv\Scripts\python.exe -m ruff check .
C:\Users\Atharva\Documents\CODEX\llm.venv\Scripts\python.exe -m mypy llm
Closes #1398