fix: remove mix_stderr=False for click 8.2.0 compatibility#1410
Open
octo-patch wants to merge 1 commit into
Open
fix: remove mix_stderr=False for click 8.2.0 compatibility#1410octo-patch wants to merge 1 commit into
octo-patch wants to merge 1 commit into
Conversation
…onw#1293) The mix_stderr parameter was removed from CliRunner in click 8.2.0. Since click 8.2.0 always captures stderr separately, remove the now-invalid mix_stderr=False argument from CliRunner() calls and drop the click<8.2.0 dev-dependency pin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1293
Problem
CliRunner(mix_stderr=False)raisesTypeError: CliRunner.__init__() got an unexpected keyword argument 'mix_stderr'with click 8.2.0, which removed this parameter. As a workaround, the project pinnedclick<8.2.0in dev dependencies, but this prevents using the latest click release.Solution
mix_stderr=Falsefrom the twoCliRunner()calls in the test suiteclick<8.2.0dev-dependency pinIn click 8.2.0+, stderr is always captured separately from stdout, so
result.stderrcontinues to work correctly without themix_stderrparameter.Testing
Both affected tests (
test_embed_multi_files_encodingandtest_gpt4o_mini_sync_and_async) still checkresult.stderrcorrectly because click 8.2.0 always separates stderr from stdout by default.