fix: prevent UNIQUE constraint error when same tool is passed twice#1419
Open
octo-patch wants to merge 1 commit into
Open
fix: prevent UNIQUE constraint error when same tool is passed twice#1419octo-patch wants to merge 1 commit into
octo-patch wants to merge 1 commit into
Conversation
…l passed twice (fixes simonw#1252) When the same tool file is passed multiple times via -T (e.g. -T llm_time -T llm_time), the tool_responses table insert fails with a UNIQUE constraint error because the same (tool_id, response_id) pair is inserted twice. Use ignore=True so that duplicate tool_responses rows are silently skipped. Co-Authored-By: Octopus <liyuan851277048@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1252
Problem
When the same tool file is passed multiple times via
-T(e.g.llm prompt -T llm_time -T llm_time ...), the database logging fails with:This happens because
ensure_tool()returns the sametool_idfor duplicate tools (tools are deduplicated by hash), but the loop inlog_to_db()callsdb["tool_responses"].insert()for each occurrence, producing two rows with the same(tool_id, response_id)primary key.Solution
Add
ignore=Trueto thetool_responses.insert()call so that duplicate(tool_id, response_id)pairs are silently skipped instead of raising an integrity error.Testing
Added a test that passes the same tool twice and confirms
exit_code == 0(previously this would raise an unhandled exception).