Skip to content

Fix accessibility command for Playwright 1.57+ #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonw merged 4 commits into from
Dec 29, 2025
Merged

Fix accessibility command for Playwright 1.57+ #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
786a0f2
Fix accessibility command for Playwright 1.57+
claude Dec 28, 2025
b2bc4fa
-3.9, +3.14
simonw Dec 28, 2025
2ccfecd
Merge branch 'main' into claude/fix-accessibility-snapshot-qzMZg
simonw Dec 29, 2025
bee2aa0
Enable accessibilty tests again
simonw Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions shot_scraper/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,9 +702,10 @@ def accessibility(
skip_or_fail(response, skip, fail)
if javascript:
_evaluate_js(page, javascript)
snapshot = page.accessibility.snapshot()
snapshot = page.locator("body").aria_snapshot()
browser_obj.close()
output.write(json.dumps(snapshot, indent=4))
# aria_snapshot() returns YAML, parse it for JSON output
output.write(json.dumps(yaml.safe_load(snapshot), indent=4))
output.write("\n")


Expand Down
18 changes: 9 additions & 9 deletions tests/run_examples.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,15 @@ shot-scraper 'https://www.owlsnearme.com/?place=127871' \
-o examples/owlsnearme-wait.jpg \
--wait-for "!!document.querySelector('section.secondary')"
# Accessibility
# #shot-scraper accessibility https://datasette.io/ \
# > examples/datasette-accessibility.json
# shot-scraper accessibility https://simonwillison.net \
# --javascript "document.getElementById('wrapper').style.display='none'" \
# > examples/simonwillison-accessibility-javascript.json
# shot-scraper accessibility https://simonwillison.net \
# --javascript "document.getElementById('wrapper').style.display='none'" \
# --output examples/simonwillison-accessibility-javascript-and-dash-output.json
# shot-scraper accessibility examples/local.html -o examples/local-accessibility.json
shot-scraper accessibility https://datasette.io/ \
> examples/datasette-accessibility.json
shot-scraper accessibility https://simonwillison.net \
--javascript "document.getElementById('wrapper').style.display='none'" \
> examples/simonwillison-accessibility-javascript.json
shot-scraper accessibility https://simonwillison.net \
--javascript "document.getElementById('wrapper').style.display='none'" \
--output examples/simonwillison-accessibility-javascript-and-dash-output.json
shot-scraper accessibility examples/local.html -o examples/local-accessibility.json
# PDF
(cd examples && shot-scraper pdf https://datasette.io/tools)
shot-scraper pdf https://datasette.io \
Expand Down