Conversation
Owner
Author
|
mypy failures: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #658 +/- ##
==========================================
+ Coverage 95.56% 95.60% +0.04%
==========================================
Files 8 8
Lines 2911 2915 +4
==========================================
+ Hits 2782 2787 +5
+ Misses 129 128 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
Author
|
The biggest remaining change is to go through the |
Owner
Author
|
I used VS Code search and replace: Replace with: I'm worried I may have clobbered some view examples though. Need to check for that. |
Owner
Author
|
Before landing this I should fix the 2 lines of missing coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs:
📚 Documentation preview 📚: https://sqlite-utils--658.org.readthedocs.build/en/658/