Remove Sentinel workaround for Click 8.3.1+#685
Merged
Conversation
Co-authored-by: simonw <9599+simonw@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove Sentinel hacks after Click 8.3.1 release
Remove Sentinel workaround for Click 8.3.1+
Nov 24, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #685 +/- ##
==========================================
+ Coverage 95.32% 95.33% +0.01%
==========================================
Files 8 8
Lines 3014 3001 -13
==========================================
- Hits 2873 2861 -12
+ Misses 141 140 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Click issue #3069 caused optional parameters to return
Sentinelobjects instead ofNone. This was fixed in Click 8.3.1, making the workaround obsolete.Changes
_value_or_none()helper function that checked forSentinelobjects_value_or_none()(11 occurrences acrossinsert_upsert_implementation(),memory(), and_maybe_register_functions())>=8.3.1inpyproject.tomlThe removed workaround was converting parameters like this:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.