Add model_slice to objective funcs to handle composed models#74
Draft
santisoler wants to merge 55 commits intomainfrom
Draft
Add model_slice to objective funcs to handle composed models#74santisoler wants to merge 55 commits intomainfrom
model_slice to objective funcs to handle composed models#74santisoler wants to merge 55 commits intomainfrom
Conversation
Start drafting classes to slice models with multiple components. These wires are intended to be used to convert a model dictionary into a 1D model array, and to slice a portion of the model array.
Add a new `operators` submodule.
Add methods to extend a matrix through a `BlockColumnMatrix` and to extend a 1D array by just filling it with zeros.
Add also a `__getitem__` method and some properties to make the arguments read-only.
I like the slicer matrix better than the linear operator.
santisoler
changed the title
model_slice argument to objective funcs to handle composed modelsmodel_slice to objective funcs to handle composed models
Add a class to represent an extended hessian matrix in objective functions.
Ditch the _slice_matrix property and make use of the ModelSlice expand methods to expand the gradient and the hessian.
Use the decorator in the DataMisfit and the mesh-based regularizations.
Use it in the BlockSquareMatrix.diagonal() method to check if the block has a diagonal method.
santisoler
force-pushed
the
model-wiring-matrix-slicer
branch
from
6376404 to
d500b1c
Compare
Decorate `hessian_approx` and `hessian_diagonal` methods in `Smallness` and `Flatness`
Member
Author
|
TODO:
|
This reverts commit 428d732.
…nal` They call other methods that already implement the reduction of the model.
Edit the decorator so it doesn't reduce the model nor expand the output of the method if the model is already reduced.
Add optional arguments to enable or disable reduction of the model and expansion of the return. Update some methods in `DataMisfit` to make use of the new features. For example, the `residual` method now is configured to reduce the model, but not expand its output. Restore decorator to `hessian_approx` and `hessian_diagonal` methods in the `DataMisfit`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle composed models (with multiple physical properties) with
WiresandModelSliceobjects.