Refactor to use FX lib for dependency injection#26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces dependency injection using FX framework into several core components of the application, including configuration loading, repository instantiation, scheduling, and the HTTP server/controller. The changes refactor constructors and wiring to use FX's dependency injection patterns, improving testability and modularity. Additionally, there are some related updates to tests and minor dependency cleanup in
go.mod.Dependency Injection and Refactoring:
Refactored the configuration loader, SQLite repository, WebSocket repository, schedule, and server controller to use FX's dependency injection (
fx.In), replacing direct instantiation with parameter structs for dependencies. This improves modularity and makes components easier to test and manage.Replaced old constructor functions (e.g.,
NewSQLite,NewWebSocket,newSessionStore, andCORSMiddleware) with versions that accept dependency-injected parameters, and updated their usages throughout the codebase and tests.Testing Updates:
Updated all repository tests in
sqlite_test.goto use the new dependency-injected constructors, passing configuration explicitly and updating references to the repository instance.Scheduling Improvements:
Refactored the scheduling logic to use FX lifecycle hooks for clean startup and shutdown, and added a stop channel for graceful termination of the background cleanup routine.