Remove CC_TEST_REPORTER_ID special case for JSON formatter

The default HTMLFormatter already writes coverage.json, so the env-var
trigger that pushed JSONFormatter onto the formatter list is redundant,
it just caused a duplicate write of the same file. With the special case
gone, `SimpleCov::Formatter.from_env` has no reason to exist, so the
default_formatter module and its spec are deleted and defaults.rb sets
HTMLFormatter directly.

Author: sferik

CHANGELOG.md

@@ -7,6 +7,7 @@ Unreleased
 * `StringFilter` now matches at path-segment boundaries. `"lib"` matches `/lib/` but no longer matches `/library/`. Use a `Regexp` filter for substring matching.
 * `SourceFile#project_filename` now returns a truly relative path with no leading separator (e.g. `lib/foo.rb` instead of `/lib/foo.rb`). This also removes the leading `/` from file path keys in `coverage.json` and from the filename in `minimum_coverage_by_file` error messages. Anchored `RegexFilter`s that relied on a leading `/` (e.g. `%r{^/lib/}`) should be rewritten (e.g. `%r{\Alib/}`).
 * Removed `docile` gem dependency. The `SimpleCov.configure` DSL block is now evaluated via `instance_exec` with instance variable proxying.
+* Removed automatic activation of `JSONFormatter` when the `CC_TEST_REPORTER_ID` environment variable is set. The default `HTMLFormatter` now always writes `coverage.json`, so the env-var special case is no longer needed.
 
 ## Enhancements
 * JSON formatter: `meta.timestamp` is now emitted with millisecond precision (`iso8601(3)`) so the concurrent-overwrite warning can distinguish writes within the same wall-clock second

README.md

@@ -905,9 +905,6 @@ SimpleCov includes a `SimpleCov::Formatter::JSONFormatter` that provides you wit
 SimpleCov.formatter = SimpleCov::Formatter::JSONFormatter
 ```
 
-> _Note:_ In case you plan to report your coverage results to CodeClimate services, know that SimpleCov will automatically use the
->  JSON formatter along with the HTML formatter when the `CC_TEST_REPORTER_ID` variable is present in the environment.
-
 > The JSON formatter was originally a separate gem called [simplecov_json_formatter](https://github.com/codeclimate-community/simplecov_json_formatter). It is now built in and loaded by default. Existing code that does `require "simplecov_json_formatter"` will continue to work.
 
 ## Available formatters, editor integrations and hosted services

features/config_json_formatter.feature

@@ -24,23 +24,3 @@ Feature:
     When I successfully run `bundle exec rake test`
     Then a JSON coverage report should have been generated in "coverage"
     And the output should contain "JSON Coverage report generated"
-
-  Scenario: When CC_TEST_REPORTER_ID is set in the environment
-    Given SimpleCov for Test/Unit is configured with:
-      """
-      require 'simplecov'
-      SimpleCov.at_exit do
-        puts SimpleCov.result.format!
-      end
-      SimpleCov.start do
-        add_group 'Libs', 'lib/faked_project/'
-      end
-      """
-    And I set the environment variables to:
-      | variable            | value   |
-      | CC_TEST_REPORTER_ID | some-id |
-
-    When I successfully run `bundle exec rake test`
-
-    Then a JSON coverage report should have been generated in "coverage"
-    And the output should contain "JSON Coverage report generated"

features/step_definitions/json_steps.rb

@@ -35,36 +35,3 @@ Feature:
 
     And the report should be based upon:
       | Unit Tests |
-
-  Scenario:
-    Given SimpleCov for Test/Unit is configured with:
-      """
-      ENV['CC_TEST_REPORTER_ID'] = "9719ac886877886b7e325d1e828373114f633683e429107d1221d25270baeabf"
-      require 'simplecov'
-      SimpleCov.start
-      """
-
-    When I open the coverage report generated with `bundle exec rake test`
-    Then I should see the groups:
-      | name      | coverage | files |
-      | All Files | 91.37%   | 6     |
-
-    And I should see the source files:
-      | name                                    | coverage |
-      | lib/faked_project.rb                    | 100.00%  |
-      | lib/faked_project/some_class.rb         | 80.00%   |
-      | lib/faked_project/framework_specific.rb | 75.00%   |
-      | lib/faked_project/meta_magic.rb         | 100.00%  |
-      | test/meta_magic_test.rb                 | 100.00%  |
-      | test/some_class_test.rb                 | 100.00%  |
-
-      # Note: faked_test.rb is not appearing here since that's the first unit test file
-      # loaded by Rake, and only there test_helper is required, which then loads simplecov
-      # and triggers tracking of all other loaded files! Solution for this would be to
-      # configure simplecov in this first test instead of test_helper.
-
-    And the report should be based upon:
-      | Unit Tests |
-
-    And a JSON coverage report should have been generated
-    And the JSON coverage report should match the output for the basic case

features/test_unit_basic.feature

@@ -1,8 +1,7 @@
 # frozen_string_literal: true
 
-# Load default formatter gem
 require "pathname"
-require_relative "default_formatter"
+require_relative "formatter/html_formatter"
 require_relative "profiles/root_filter"
 require_relative "profiles/test_frameworks"
 require_relative "profiles/bundler_filter"
@@ -11,9 +10,7 @@
 
 # Default configuration
 SimpleCov.configure do
-  formatter SimpleCov::Formatter::MultiFormatter.new(
-    SimpleCov::Formatter.from_env(ENV)
-  )
+  formatter SimpleCov::Formatter::HTMLFormatter
 
   load_profile "bundler_filter"
   load_profile "hidden_filter"