Restore capture_stderr helper used by JSON formatter specs#1177
Merged
Conversation
sferik
force-pushed
the
restore-capture-stderr-helper
branch
from
cb1cf4e to
0d3eda0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores
capture_stderrtospec/helper.rb. It was dropped in 2729bdf when nothing was using it, but the concurrent-overwrite warning specs added in f9b698a depend on it. The two changes only collided after rebase, so the merged tip of main fails on every Ruby version withNoMethodError: undefined method 'capture_stderr'in four examples inspec/json_formatter_spec.rb.