removing materialized reporting_facility_appointment_scheduled_days (#5816)

**Story card:**
[SIMPLEBACK-127](https://rtsl.atlassian.net/browse/SIMPLEBACK-127)

## Because

We want to discard materialized
reporting_facility_appointment_scheduled_days

## This addresses

We create a normal view reporting_facility_appointment_scheduled_days
under public schema. This will ensure that the existing dashboard and
metabase reports don't break.

## Test instructions

Clear the cache and restart the server. The dashboards should load fine.
Suite tests.

---------

Co-authored-by: Ayushi Agrawal <ayushiagrawal@RTSL-P172G93770.local>

Author: aagrawalrtsl

app/models/reports/facility_appointment_scheduled_days.rb

@@ -4,7 +4,7 @@ class FacilityAppointmentScheduledDays < Reports::View
     belongs_to :facility
 
     def self.materialized?
-      true
+      false
     end
 
     def self.partitioned?

db/migrate/20260610061836_discard_mat_view_reporting_facility_appointment_scheduled_days.rb

@@ -0,0 +1,73 @@
+class DiscardMatViewReportingFacilityAppointmentScheduledDays < ActiveRecord::Migration[6.1]
+  def up
+    drop_view :reporting_facility_appointment_scheduled_days, materialized: true
+
+    execute <<~SQL
+      CREATE VIEW public.reporting_facility_appointment_scheduled_days AS SELECT * FROM simple_reporting.reporting_facility_appointment_scheduled_days;
+    SQL
+  end
+
+  def down
+    drop_view :reporting_facility_appointment_scheduled_days
+
+    execute <<~SQL
+      CREATE MATERIALIZED VIEW public.reporting_facility_appointment_scheduled_days AS
+      WITH latest_medical_histories AS (
+        SELECT DISTINCT ON (patient_id) mh.*
+        FROM medical_histories mh
+        WHERE  mh.deleted_at IS NULL
+        ORDER BY patient_id, mh.device_created_at DESC
+      ),
+      latest_appointments_per_patient_per_month AS (
+        SELECT DISTINCT ON (patient_id, month_date) a.*,
+          lmh.hypertension,
+          lmh.diabetes,
+          to_char(a.device_created_at AT TIME ZONE 'UTC' AT TIME ZONE (SELECT current_setting('TIMEZONE')), 'YYYY-MM-01')::date month_date
+        FROM appointments a
+        INNER JOIN patients p ON p.id = a.patient_id
+        INNER JOIN latest_medical_histories lmh ON lmh.patient_id = a.patient_id
+        WHERE a.scheduled_date >= date_trunc('day', a.device_created_at AT TIME ZONE 'UTC' AT TIME ZONE (SELECT current_setting('TIMEZONE')))
+          AND a.device_created_at >= date_trunc('month', (now() AT TIME ZONE 'UTC') - INTERVAL '6 months')
+          AND date_trunc('month', a.device_created_at AT TIME ZONE 'UTC' AT TIME ZONE (SELECT current_setting('TIMEZONE')))
+            > date_trunc('month', p.recorded_at AT TIME ZONE 'UTC' AT TIME ZONE (SELECT current_setting('TIMEZONE')))
+          AND p.deleted_at IS NULL AND p.diagnosed_confirmed_at IS NOT NULL
+          AND a.deleted_at IS NULL
+          AND (lmh.hypertension = 'yes'  OR lmh.diabetes = 'yes')
+        ORDER BY a.patient_id, month_date, a.device_created_at desc
+      ),
+      scheduled_days_distribution AS (
+        SELECT month_date,
+          width_bucket(
+            extract('days' FROM (scheduled_date - date_trunc('day', device_created_at AT TIME ZONE 'UTC' AT TIME ZONE (SELECT current_setting('TIMEZONE')))))::integer,
+            array[0, 15, 32, 63]
+          ) bucket,
+          COUNT(*) number_of_appointments,
+          hypertension,
+          diabetes,
+          creation_facility_id facility_id
+        FROM latest_appointments_per_patient_per_month
+        GROUP BY bucket, creation_facility_id, month_date, hypertension, diabetes
+      )
+      SELECT facility_id,
+        month_date,
+        (SUM(number_of_appointments) FILTER (WHERE bucket = 1 AND hypertension = 'yes'))::integer AS htn_appts_scheduled_0_to_14_days,
+        (SUM(number_of_appointments) FILTER (WHERE bucket = 2 AND hypertension = 'yes'))::integer AS htn_appts_scheduled_15_to_31_days,
+        (SUM(number_of_appointments) FILTER (WHERE bucket = 3 AND hypertension = 'yes'))::integer AS htn_appts_scheduled_32_to_62_days,
+        (SUM(number_of_appointments) FILTER (WHERE bucket = 4 AND hypertension = 'yes'))::integer AS htn_appts_scheduled_more_than_62_days,
+        (SUM(number_of_appointments) FILTER (WHERE hypertension = 'yes'))::integer htn_total_appts_scheduled,
+
+        (SUM(number_of_appointments) FILTER (WHERE bucket = 1 AND diabetes = 'yes'))::integer AS diabetes_appts_scheduled_0_to_14_days,
+        (SUM(number_of_appointments) FILTER (WHERE bucket = 2 AND diabetes = 'yes'))::integer AS diabetes_appts_scheduled_15_to_31_days,
+        (SUM(number_of_appointments) FILTER (WHERE bucket = 3 AND diabetes = 'yes'))::integer AS diabetes_appts_scheduled_32_to_62_days,
+        (SUM(number_of_appointments) FILTER (WHERE bucket = 4 AND diabetes = 'yes'))::integer AS diabetes_appts_scheduled_more_than_62_days,
+        (SUM(number_of_appointments) FILTER (WHERE diabetes = 'yes'))::integer diabetes_total_appts_scheduled
+      FROM scheduled_days_distribution
+      GROUP BY facility_id, month_date
+      WITH NO DATA;
+    SQL
+
+    execute <<~SQL
+      CREATE UNIQUE INDEX index_reporting_facility_appointment_scheduled_days ON public.reporting_facility_appointment_scheduled_days USING btree (month_date, facility_id);
+    SQL
+  end
+end

db/structure.sql

@@ -4296,63 +4296,10 @@ COMMENT ON COLUMN public.reporting_facilities.organization_slug IS 'Human readab
 
 
 --
--- Name: reporting_facility_appointment_scheduled_days; Type: MATERIALIZED VIEW; Schema: public; Owner: -
+-- Name: reporting_facility_appointment_scheduled_days; Type: VIEW; Schema: public; Owner: -
 --
 
-CREATE MATERIALIZED VIEW public.reporting_facility_appointment_scheduled_days AS
-    WITH latest_medical_histories AS (
-        SELECT DISTINCT ON (patient_id) mh.*
-        FROM public.medical_histories mh
-        WHERE  mh.deleted_at IS NULL
-        ORDER BY patient_id, mh.device_created_at DESC
-    ),
-    latest_appointments_per_patient_per_month AS (
-        SELECT DISTINCT ON (patient_id, month_date) a.*,
-            lmh.hypertension,
-            lmh.diabetes,
-            to_char(a.device_created_at AT TIME ZONE 'UTC' AT TIME ZONE (SELECT current_setting('TIMEZONE')), 'YYYY-MM-01')::date month_date
-        FROM public.appointments a
-        INNER JOIN public.patients p ON p.id = a.patient_id
-        INNER JOIN latest_medical_histories lmh ON lmh.patient_id = a.patient_id
-        WHERE a.scheduled_date >= date_trunc('day', a.device_created_at AT TIME ZONE 'UTC' AT TIME ZONE (SELECT current_setting('TIMEZONE')))
-        AND a.device_created_at >= date_trunc('month', (now() AT TIME ZONE 'UTC') - INTERVAL '6 months')
-        AND date_trunc('month', a.device_created_at AT TIME ZONE 'UTC' AT TIME ZONE (SELECT current_setting('TIMEZONE')))
-            > date_trunc('month', p.recorded_at AT TIME ZONE 'UTC' AT TIME ZONE (SELECT current_setting('TIMEZONE')))
-        AND p.deleted_at IS NULL AND p.diagnosed_confirmed_at IS NOT NULL
-        AND a.deleted_at IS NULL
-        AND (lmh.hypertension = 'yes'  OR lmh.diabetes = 'yes')
-        ORDER BY a.patient_id, month_date, a.device_created_at desc
-    ),
-    scheduled_days_distribution AS (
-        SELECT month_date,
-                width_bucket(
-                extract('days' FROM (scheduled_date - date_trunc('day', device_created_at AT TIME ZONE 'UTC' AT TIME ZONE (SELECT current_setting('TIMEZONE')))))::integer,
-                array[0, 15, 32, 63]
-                ) bucket,
-                COUNT(*) number_of_appointments,
-                hypertension,
-                diabetes,
-                creation_facility_id facility_id
-        FROM latest_appointments_per_patient_per_month
-        GROUP BY bucket, creation_facility_id, month_date, hypertension, diabetes)
-
-    SELECT facility_id,
-        month_date,
-        (SUM(number_of_appointments) FILTER (WHERE bucket = 1 AND hypertension = 'yes'))::integer AS htn_appts_scheduled_0_to_14_days,
-        (SUM(number_of_appointments) FILTER (WHERE bucket = 2 AND hypertension = 'yes'))::integer AS htn_appts_scheduled_15_to_31_days,
-        (SUM(number_of_appointments) FILTER (WHERE bucket = 3 AND hypertension = 'yes'))::integer AS htn_appts_scheduled_32_to_62_days,
-        (SUM(number_of_appointments) FILTER (WHERE bucket = 4 AND hypertension = 'yes'))::integer AS htn_appts_scheduled_more_than_62_days,
-        (SUM(number_of_appointments) FILTER (WHERE hypertension = 'yes'))::integer htn_total_appts_scheduled,
-
-        (SUM(number_of_appointments) FILTER (WHERE bucket = 1 AND diabetes = 'yes'))::integer AS diabetes_appts_scheduled_0_to_14_days,
-        (SUM(number_of_appointments) FILTER (WHERE bucket = 2 AND diabetes = 'yes'))::integer AS diabetes_appts_scheduled_15_to_31_days,
-        (SUM(number_of_appointments) FILTER (WHERE bucket = 3 AND diabetes = 'yes'))::integer AS diabetes_appts_scheduled_32_to_62_days,
-        (SUM(number_of_appointments) FILTER (WHERE bucket = 4 AND diabetes = 'yes'))::integer AS diabetes_appts_scheduled_more_than_62_days,
-        (SUM(number_of_appointments) FILTER (WHERE diabetes = 'yes'))::integer diabetes_total_appts_scheduled
-    FROM scheduled_days_distribution
-    GROUP BY facility_id, month_date
-  WITH NO DATA;
-
+CREATE VIEW public.reporting_facility_appointment_scheduled_days AS SELECT * FROM simple_reporting.reporting_facility_appointment_scheduled_days;
 
 --
 -- Name: reporting_facility_daily_follow_ups_and_registrations; Type: MATERIALIZED VIEW; Schema: public; Owner: -
@@ -8584,13 +8531,6 @@ CREATE UNIQUE INDEX index_regions_on_unique_path ON public.regions USING btree (
 CREATE INDEX index_reminder_templates_on_treatment_group_id ON public.reminder_templates USING btree (treatment_group_id);
 
 
---
--- Name: index_reporting_facility_appointment_scheduled_days; Type: INDEX; Schema: public; Owner: -
---
-
-CREATE UNIQUE INDEX index_reporting_facility_appointment_scheduled_days ON public.reporting_facility_appointment_scheduled_days USING btree (month_date, facility_id);
-
-
 --
 -- Name: index_reporting_patient_follow_ups_on_facility_id; Type: INDEX; Schema: public; Owner: -
 --
@@ -9574,6 +9514,7 @@ INSERT INTO "schema_migrations" (version) VALUES
 ('20260513141718'),
 ('20260515103653'),
 ('20260521101357'),
-('20260528053923');
+('20260528053923'),
+('20260610061836');
 
 

db/views/reporting_facility_appointment_scheduled_days_v04.sql

@@ -1,6 +1,13 @@
 require "rails_helper"
 
 describe MonthlyDistrictData::DiabetesDataExporter do
+  def stub_get_refresh_months_for(*classes)
+    classes.each do |klass|
+      allow(klass).to receive(:get_refresh_months)
+        .and_return(ReportingHelpers.get_refresh_months_between_dates(2.years.ago.to_date, Date.today))
+    end
+  end
+
   around do |example|
     # This is in the style of ReportingHelpers::freeze_time_for_reporting_specs.
     # Since FacilityAppointmentScheduledDays only keeps the last 6 months of data, the date cannot be a
@@ -36,8 +43,7 @@
     create(:appointment, facility: @facility1, scheduled_date: Date.today, device_created_at: 63.days.ago, patient: create(:patient, :diabetes, recorded_at: 1.year.ago))
 
     @months = @period.downto(5).reverse.map(&:to_s)
-    allow(Reports::PatientState).to receive(:get_refresh_months).and_return(ReportingHelpers.get_refresh_months_between_dates(2.years.ago.to_date, Date.today))
-    allow(Reports::FacilityState).to receive(:get_refresh_months).and_return(ReportingHelpers.get_refresh_months_between_dates(2.years.ago.to_date, Date.today))
+    stub_get_refresh_months_for(Reports::PatientState, Reports::FacilityState, Reports::FacilityAppointmentScheduledDays)
     RefreshReportingViews.refresh_v2
   end
 

db/views/reporting_facility_appointment_scheduled_days_v05.sql

@@ -1,6 +1,13 @@
 require "rails_helper"
 
 describe MonthlyDistrictData::HypertensionDataExporter do
+  def stub_get_refresh_months_for(*classes)
+    classes.each do |klass|
+      allow(klass).to receive(:get_refresh_months)
+        .and_return(ReportingHelpers.get_refresh_months_between_dates(2.years.ago.to_date, Date.today))
+    end
+  end
+
   around do |example|
     # This is in the style of ReportingHelpers::freeze_time_for_reporting_specs.
     # Since FacilityAppointmentScheduledDays only keeps the last 6 months of data, the date cannot be a
@@ -34,8 +41,7 @@
     create(:appointment, facility: @facility1, scheduled_date: Date.today, device_created_at: 63.days.ago, patient: create(:patient, recorded_at: 1.year.ago))
 
     @months = @period.downto(5).reverse.map(&:to_s)
-    allow(Reports::PatientState).to receive(:get_refresh_months).and_return(ReportingHelpers.get_refresh_months_between_dates(2.years.ago.to_date, Date.today))
-    allow(Reports::FacilityState).to receive(:get_refresh_months).and_return(ReportingHelpers.get_refresh_months_between_dates(2.years.ago.to_date, Date.today))
+    stub_get_refresh_months_for(Reports::PatientState, Reports::FacilityState, Reports::FacilityAppointmentScheduledDays)
     RefreshReportingViews.refresh_v2
   end
 

spec/exporters/monthly_district_data/diabetes_data_exporter_spec.rb

@@ -1,6 +1,13 @@
 require "rails_helper"
 
 describe MonthlyStateData::DiabetesDataExporter do
+  def stub_get_refresh_months_for(*classes)
+    classes.each do |klass|
+      allow(klass).to receive(:get_refresh_months)
+        .and_return(ReportingHelpers.get_refresh_months_between_dates(3.months.ago.to_date, Date.today))
+    end
+  end
+
   around do |example|
     # This is in the style of ReportingHelpers::freeze_time_for_reporting_specs.
     # Since FacilityAppointmentScheduledDays only keeps the last 6 months of data, the date cannot be a
@@ -38,8 +45,7 @@
     create(:appointment, facility: @facility1, scheduled_date: Date.today, device_created_at: 63.days.ago, patient: create(:patient, :diabetes, recorded_at: 1.year.ago))
 
     @months = @period.downto(5).reverse.map(&:to_s)
-    allow(Reports::PatientState).to receive(:get_refresh_months).and_return(ReportingHelpers.get_refresh_months_between_dates(3.months.ago.to_date, Date.today))
-    allow(Reports::FacilityState).to receive(:get_refresh_months).and_return(ReportingHelpers.get_refresh_months_between_dates(3.months.ago.to_date, Date.today))
+    stub_get_refresh_months_for(Reports::PatientState, Reports::FacilityState, Reports::FacilityAppointmentScheduledDays)
     RefreshReportingViews.refresh_v2
   end