Ticket #917 : Return 404 (scim)

Author: habarthierry-hue

src/Scim/SimpleIdServer.Scim.Persistence.EF/Extensions/EFSCIMExpressionLinqExtensions.cs

@@ -13,7 +13,6 @@
 using System.Reflection;
 using System.Threading;
 using System.Threading.Tasks;
-using System.Xml.XPath;
 
 namespace SimpleIdServer.Scim.Persistence.EF.Extensions
 {
@@ -46,6 +45,11 @@ public static async Task<SCIMRepresentation> BuildResult(
             {
                 filteredAttrs = filteredAttrs.Where(a => a.RepresentationId == id);
                 var result = await GetRepresentation(representations, id, resourceType, realm, cancellationToken);
+                if(result == null)
+                {
+                    return null;
+                }
+
                 result.FlatAttributes = filteredAttrs.ToList();
                 return result;
             }

tests/SimpleIdServer.Scim.Host.Acceptance.Tests/Features/GroupErrors.feature

@@ -16,4 +16,15 @@ Scenario: Check group cannot have a self reference
 	And extract JSON from body
 
 	Then HTTP status code equals to '500'
-	Then JSON 'detail'='Representation cannot have a self reference'
+	Then JSON 'detail'='Representation cannot have a self reference'
+
+Scenario: When group doesn't exist and the parameter exclusedAttributes is passed into the request then an error 404 is returned
+	When execute HTTP GET request 'http://localhost/Groups/invalid?excludedAttributes=members'
+	
+	And extract JSON from body
+	
+	Then HTTP status code equals to '404'
+	Then JSON 'status'='404'
+	Then JSON 'schemas[0]'='urn:ietf:params:scim:api:messages:2.0:Error'
+	Then JSON 'scimType'='unknown'
+	Then JSON 'detail'='resource invalid not found'