Ticket #929 : Don't publish events

habarthierry-hue · habarthierry-hue · commit a791445195e5 · 2025-10-09T16:12:41.000+02:00
diff --git a/src/Scim/SimpleIdServer.Scim/Api/BaseApiController.cs b/src/Scim/SimpleIdServer.Scim/Api/BaseApiController.cs
@@ -349,7 +349,7 @@ protected async Task<IActionResult> InternalAdd(string prefix, RepresentationPar
             _logger.LogInformation(Global.AddResource);
             try
             {
-                var command = new AddRepresentationCommand(_resourceType, jobj, _uriProvider.GetAbsoluteUriWithVirtualPath(), realm);
+                var command = new AddRepresentationCommand(_resourceType, jobj, _uriProvider.GetAbsoluteUriWithVirtualPath(), realm, IsPublishEvtsEnabled);
                 var addRepresentationResult = await _addRepresentationCommandHandler.Handle(command);
                 if (addRepresentationResult.HasError) return this.BuildError(addRepresentationResult);
                 var representation = addRepresentationResult.Result;
@@ -398,13 +398,17 @@ protected async Task<IActionResult> InternalDelete(string prefix, string id, Can
             _logger.LogInformation(string.Format(Global.DeleteResource, id));
             try
             {
-                var getRepresentationResult = await _deleteRepresentationCommandHandler.Handle(new DeleteRepresentationCommand(id, _resourceType, _uriProvider.GetAbsoluteUriWithVirtualPath(), realm));
+                var getRepresentationResult = await _deleteRepresentationCommandHandler.Handle(new DeleteRepresentationCommand(id, _resourceType, _uriProvider.GetAbsoluteUriWithVirtualPath(), realm, IsPublishEvtsEnabled));
                 if (getRepresentationResult.HasError) return this.BuildError(getRepresentationResult);
                 var representation = getRepresentationResult.Result;
                 representation.ApplyEmptyArray();
                 var location = GetLocation(realm, representation);
                 var content = representation.ToResponse(location, false, mergeExtensionAttributes: _options.MergeExtensionAttributes);
-                if (IsPublishEvtsEnabled) await _busControl.Publish(new RepresentationRemovedEvent(id, representation.Version, GetResourceType(_resourceType), realm, content, _options.IncludeToken ? Request.GetToken() : string.Empty));
+                if (IsPublishEvtsEnabled)
+                {
+                    await _busControl.Publish(new RepresentationRemovedEvent(id, representation.Version, GetResourceType(_resourceType), realm, content, _options.IncludeToken ? Request.GetToken() : string.Empty));
+                }
+
                 return new StatusCodeResult((int)HttpStatusCode.NoContent);
             }
             catch (SCIMSchemaViolatedException ex)
@@ -442,7 +446,7 @@ protected async Task<IActionResult> InternalUpdate(string prefix, string id, Rep
             _logger.LogInformation(Global.UpdateResource, id);
             try
             {
-                var updateResult = await _replaceRepresentationCommandHandler.Handle(new ReplaceRepresentationCommand(id, _resourceType, representationParameter, _uriProvider.GetAbsoluteUriWithVirtualPath(), realm));
+                var updateResult = await _replaceRepresentationCommandHandler.Handle(new ReplaceRepresentationCommand(id, _resourceType, representationParameter, _uriProvider.GetAbsoluteUriWithVirtualPath(), realm, IsPublishEvtsEnabled));
                 if (updateResult.HasError) return this.BuildError(updateResult);
                 if (!updateResult.Result.IsReplaced) return NoContent();
                 var representation = updateResult.Result.Representation;
@@ -515,7 +519,7 @@ protected async Task<IActionResult> InternalPatch(string prefix, string id, Patc
             _logger.LogInformation(string.Format(Global.PatchResource, id, patchRepresentation == null ? string.Empty : JsonSerializer.Serialize(patchRepresentation)));
             try
             {
-                var patchRes = await _patchRepresentationCommandHandler.Handle(new PatchRepresentationCommand(id, ResourceType, patchRepresentation, _uriProvider.GetAbsoluteUriWithVirtualPath(), realm));
+                var patchRes = await _patchRepresentationCommandHandler.Handle(new PatchRepresentationCommand(id, ResourceType, patchRepresentation, _uriProvider.GetAbsoluteUriWithVirtualPath(), realm, IsPublishEvtsEnabled));
                 if (patchRes.HasError) return this.BuildError(patchRes);
                 var patchResult = patchRes.Result;
                 if (!patchResult.IsPatched) return NoContent();
@@ -525,9 +529,7 @@ protected async Task<IActionResult> InternalPatch(string prefix, string id, Patc
                 if(!_options.IsFullRepresentationReturned)
                 {
                     var content = representation.ToResponse(location, true, mergeExtensionAttributes: _options.MergeExtensionAttributes);
-                    if (IsPublishEvtsEnabled)
-                        await _busControl.Publish(new RepresentationUpdatedEvent(representation.Id, representation.Version, GetResourceType(_resourceType), realm, content, _options.IncludeToken ? Request.GetToken() : string.Empty, patchRes.Result.PatchOperations));
-                    
+                    if (IsPublishEvtsEnabled) await _busControl.Publish(new RepresentationUpdatedEvent(representation.Id, representation.Version, GetResourceType(_resourceType), realm, content, _options.IncludeToken ? Request.GetToken() : string.Empty, patchRes.Result.PatchOperations));
                     return BuildHTTPResult(HttpStatusCode.OK, location, representation.Version, content);
                 }
                 else
diff --git a/src/Scim/SimpleIdServer.Scim/Commands/AddRepresentationCommand.cs b/src/Scim/SimpleIdServer.Scim/Commands/AddRepresentationCommand.cs
@@ -8,17 +8,19 @@ namespace SimpleIdServer.Scim.Commands
 {
     public class AddRepresentationCommand : ISCIMCommand<SCIMRepresentation>
     {
-        public AddRepresentationCommand(string resourceType, RepresentationParameter representation, string location, string realm)
+        public AddRepresentationCommand(string resourceType, RepresentationParameter representation, string location, string realm, bool isPublishEvtsEnabled)
         {
             ResourceType = resourceType;
             Representation = representation;
             Location = location;
             Realm = realm;
+            IsPublishEvtsEnabled = isPublishEvtsEnabled;
         }
 
         public string ResourceType { get; set; }
         public RepresentationParameter Representation { get; }
         public string Location { get; }
         public string Realm { get; set; }
+        public bool IsPublishEvtsEnabled { get; set; }
     }
 }
diff --git a/src/Scim/SimpleIdServer.Scim/Commands/DeleteRepresentationCommand.cs b/src/Scim/SimpleIdServer.Scim/Commands/DeleteRepresentationCommand.cs
@@ -7,17 +7,19 @@ namespace SimpleIdServer.Scim.Commands
 {
     public class DeleteRepresentationCommand : ISCIMCommand<SCIMRepresentation>
     {
-        public DeleteRepresentationCommand(string id, string resourceType, string location, string realm)
+        public DeleteRepresentationCommand(string id, string resourceType, string location, string realm, bool isPublishEvtsEnabled)
         {
             Id = id;
             ResourceType = resourceType;
             Location = location;
             Realm = realm;
+            IsPublishEvtsEnabled = isPublishEvtsEnabled;
         }
 
         public string Id { get; set; }
         public string ResourceType { get; set; }
         public string Location { get; }
         public string Realm { get; set; }
+        public bool IsPublishEvtsEnabled { get; set; }
     }
 }
diff --git a/src/Scim/SimpleIdServer.Scim/Commands/Handlers/AddRepresentationCommandHandler.cs b/src/Scim/SimpleIdServer.Scim/Commands/Handlers/AddRepresentationCommandHandler.cs
@@ -88,7 +88,10 @@ public async virtual Task<GenericResult<SCIMRepresentation>> Handle(AddRepresent
                 }
 
                 await transaction.Commit().ConfigureAwait(false);
-                await NotifyAllReferences(references).ConfigureAwait(false);
+                if(addRepresentationCommand.IsPublishEvtsEnabled)
+                {
+                    await NotifyAllReferences(references).ConfigureAwait(false);
+                }
             }
 
             scimRepresentation.Apply(references, patchOperations);
diff --git a/src/Scim/SimpleIdServer.Scim/Commands/Handlers/DeleteRepresentationCommandHandler.cs b/src/Scim/SimpleIdServer.Scim/Commands/Handlers/DeleteRepresentationCommandHandler.cs
@@ -55,7 +55,10 @@ public virtual async Task<GenericResult<SCIMRepresentation>> Handle(DeleteRepres
 
                 await _scimRepresentationCommandRepository.Delete(representation).ConfigureAwait(false);
                 await transaction.Commit().ConfigureAwait(false);
-                await NotifyAllReferences(references).ConfigureAwait(false);
+                if(request.IsPublishEvtsEnabled)
+                {
+                    await NotifyAllReferences(references).ConfigureAwait(false);
+                }
             }
 
             return GenericResult<SCIMRepresentation>.Ok(result);
diff --git a/src/Scim/SimpleIdServer.Scim/Commands/Handlers/PatchRepresentationCommandHandler.cs b/src/Scim/SimpleIdServer.Scim/Commands/Handlers/PatchRepresentationCommandHandler.cs
@@ -83,7 +83,10 @@ private async Task<GenericResult<PatchRepresentationResult>> UpdateRepresentatio
 
                 await _scimRepresentationCommandRepository.Update(existingRepresentation).ConfigureAwait(false);
                 await transaction.Commit().ConfigureAwait(false);
-                await NotifyAllReferences(references).ConfigureAwait(false);
+                if(patchRepresentationCommand.IsPublishEvtsEnabled)
+                {
+                    await NotifyAllReferences(references).ConfigureAwait(false);
+                }
             }
 
             existingRepresentation.Apply(references, patchResultLst);
diff --git a/src/Scim/SimpleIdServer.Scim/Commands/Handlers/ReplaceRepresentationCommandHandler.cs b/src/Scim/SimpleIdServer.Scim/Commands/Handlers/ReplaceRepresentationCommandHandler.cs
@@ -76,7 +76,10 @@ public async virtual Task<GenericResult<ReplaceRepresentationResult>> Handle(Rep
 
                 await _scimRepresentationCommandRepository.Update(existingRepresentation).ConfigureAwait(false);
                 await transaction.Commit().ConfigureAwait(false);
-                await NotifyAllReferences(references).ConfigureAwait(false);
+                if(replaceRepresentationCommand.IsPublishEvtsEnabled)
+                {
+                    await NotifyAllReferences(references).ConfigureAwait(false);
+                }
             }
 
             existingRepresentation.Apply(references, patchOperations);
diff --git a/src/Scim/SimpleIdServer.Scim/Commands/PatchRepresentationCommand.cs b/src/Scim/SimpleIdServer.Scim/Commands/PatchRepresentationCommand.cs
@@ -9,20 +9,22 @@ namespace SimpleIdServer.Scim.Commands
 {
     public class PatchRepresentationCommand : ISCIMCommand<PatchRepresentationResult>
     {
-        public PatchRepresentationCommand(string id, string resourceType, PatchRepresentationParameter patchRepresentation, string location, string realm)
+        public PatchRepresentationCommand(string id, string resourceType, PatchRepresentationParameter patchRepresentation, string location, string realm, bool isPublishEvtsEnabled)
         {
             Id = id;
             ResourceType = resourceType;
             PatchRepresentation = patchRepresentation;
             Location = location;
             Realm = realm;
+            IsPublishEvtsEnabled = isPublishEvtsEnabled;
         }
 
         public string Id { get; private set; }
         public PatchRepresentationParameter PatchRepresentation { get; private set; }
         public string ResourceType { get; private set; }
         public string Location { get; }
         public string Realm { get; set; }
+        public bool IsPublishEvtsEnabled {  get; set; }
     }
 
     public class PatchRepresentationResult
diff --git a/src/Scim/SimpleIdServer.Scim/Commands/ReplaceRepresentationCommand.cs b/src/Scim/SimpleIdServer.Scim/Commands/ReplaceRepresentationCommand.cs
@@ -9,20 +9,22 @@ namespace SimpleIdServer.Scim.Commands
 {
     public class ReplaceRepresentationCommand : ISCIMCommand<ReplaceRepresentationResult>
     {
-        public ReplaceRepresentationCommand(string id, string resourceType, RepresentationParameter representation, string location, string realm)
+        public ReplaceRepresentationCommand(string id, string resourceType, RepresentationParameter representation, string location, string realm, bool isPublishEvtsEnabled)
         {
             Id = id;
             ResourceType = resourceType;
             Representation = representation;
             Location = location;
             Realm = realm;
+            IsPublishEvtsEnabled = isPublishEvtsEnabled;
         }
 
         public string Id { get; private set; }
         public string ResourceType{ get; private set; }
         public RepresentationParameter Representation { get; private set; }
         public string Location { get; }
         public string Realm { get; set; }
+        public bool IsPublishEvtsEnabled { get; set; }
     }
 
     public class ReplaceRepresentationResult

Original file line number	Diff line number	Diff line change
`@@ -8,17 +8,19 @@ namespace SimpleIdServer.Scim.Commands`
`8`	`8`	`{`
`9`	`9`	`public class AddRepresentationCommand : ISCIMCommand<SCIMRepresentation>`
`10`	`10`	`{`
`11`		`- public AddRepresentationCommand(string resourceType, RepresentationParameter representation, string location, string realm)`
	`11`	`+ public AddRepresentationCommand(string resourceType, RepresentationParameter representation, string location, string realm, bool isPublishEvtsEnabled)`
`12`	`12`	`{`
`13`	`13`	`ResourceType = resourceType;`
`14`	`14`	`Representation = representation;`
`15`	`15`	`Location = location;`
`16`	`16`	`Realm = realm;`
	`17`	`+ IsPublishEvtsEnabled = isPublishEvtsEnabled;`
`17`	`18`	`}`
`18`	`19`
`19`	`20`	`public string ResourceType { get; set; }`
`20`	`21`	`public RepresentationParameter Representation { get; }`
`21`	`22`	`public string Location { get; }`
`22`	`23`	`public string Realm { get; set; }`
	`24`	`+ public bool IsPublishEvtsEnabled { get; set; }`
`23`	`25`	`}`
`24`	`26`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,17 +7,19 @@ namespace SimpleIdServer.Scim.Commands`
`7`	`7`	`{`
`8`	`8`	`public class DeleteRepresentationCommand : ISCIMCommand<SCIMRepresentation>`
`9`	`9`	`{`
`10`		`- public DeleteRepresentationCommand(string id, string resourceType, string location, string realm)`
	`10`	`+ public DeleteRepresentationCommand(string id, string resourceType, string location, string realm, bool isPublishEvtsEnabled)`
`11`	`11`	`{`
`12`	`12`	`Id = id;`
`13`	`13`	`ResourceType = resourceType;`
`14`	`14`	`Location = location;`
`15`	`15`	`Realm = realm;`
	`16`	`+ IsPublishEvtsEnabled = isPublishEvtsEnabled;`
`16`	`17`	`}`
`17`	`18`
`18`	`19`	`public string Id { get; set; }`
`19`	`20`	`public string ResourceType { get; set; }`
`20`	`21`	`public string Location { get; }`
`21`	`22`	`public string Realm { get; set; }`
	`23`	`+ public bool IsPublishEvtsEnabled { get; set; }`
`22`	`24`	`}`
`23`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,10 @@ public async virtual Task<GenericResult<SCIMRepresentation>> Handle(AddRepresent`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`await transaction.Commit().ConfigureAwait(false);`
`91`		`- await NotifyAllReferences(references).ConfigureAwait(false);`
	`91`	`+ if(addRepresentationCommand.IsPublishEvtsEnabled)`
	`92`	`+ {`
	`93`	`+ await NotifyAllReferences(references).ConfigureAwait(false);`
	`94`	`+ }`
`92`	`95`	`}`
`93`	`96`
`94`	`97`	`scimRepresentation.Apply(references, patchOperations);`
Original file line number	Diff line number	Diff line change
`@@ -9,20 +9,22 @@ namespace SimpleIdServer.Scim.Commands`
`9`	`9`	`{`
`10`	`10`	`public class PatchRepresentationCommand : ISCIMCommand<PatchRepresentationResult>`
`11`	`11`	`{`
`12`		`- public PatchRepresentationCommand(string id, string resourceType, PatchRepresentationParameter patchRepresentation, string location, string realm)`
	`12`	`+ public PatchRepresentationCommand(string id, string resourceType, PatchRepresentationParameter patchRepresentation, string location, string realm, bool isPublishEvtsEnabled)`
`13`	`13`	`{`
`14`	`14`	`Id = id;`
`15`	`15`	`ResourceType = resourceType;`
`16`	`16`	`PatchRepresentation = patchRepresentation;`
`17`	`17`	`Location = location;`
`18`	`18`	`Realm = realm;`
	`19`	`+ IsPublishEvtsEnabled = isPublishEvtsEnabled;`
`19`	`20`	`}`
`20`	`21`
`21`	`22`	`public string Id { get; private set; }`
`22`	`23`	`public PatchRepresentationParameter PatchRepresentation { get; private set; }`
`23`	`24`	`public string ResourceType { get; private set; }`
`24`	`25`	`public string Location { get; }`
`25`	`26`	`public string Realm { get; set; }`
	`27`	`+ public bool IsPublishEvtsEnabled { get; set; }`
`26`	`28`	`}`
`27`	`29`
`28`	`30`	`public class PatchRepresentationResult`