Skip to content

Commit 5d236e4

Browse files
committed
Bump minimum PHP-version to 8.5
1 parent f84e09b commit 5d236e4

3 files changed

Lines changed: 15 additions & 10 deletions

File tree

.github/workflows/php.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
strategy:
2020
fail-fast: false
2121
matrix:
22-
php-version: ['8.3', '8.4', '8.5']
22+
php-version: ['8.5']
2323

2424
uses: simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_phplinter.yml@v1
2525
secrets: inherit
@@ -47,7 +47,7 @@ jobs:
4747
fail-fast: false
4848
matrix:
4949
operating-system: [ubuntu-latest]
50-
php-versions: ['8.3', '8.4', '8.5']
50+
php-versions: ['8.5']
5151

5252
steps:
5353
- name: Setup PHP, with composer and extensions
@@ -109,7 +109,7 @@ jobs:
109109
fail-fast: true
110110
matrix:
111111
operating-system: [windows-latest]
112-
php-versions: ['8.3', '8.4', '8.5']
112+
php-versions: ['8.5']
113113

114114
steps:
115115
- name: Setup PHP, with composer and extensions
@@ -216,7 +216,7 @@ jobs:
216216
uses: shivammathur/setup-php@v2
217217
with:
218218
# Should be the lowest supported version
219-
php-version: '8.3'
219+
php-version: '8.5'
220220
extensions: ctype, date, dom, filter, hash, mbstring, openssl, pcre, soap, spl, xml
221221
tools: composer
222222
coverage: none

composer.json

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@
1313
}
1414
],
1515
"require": {
16-
"php": "^8.3",
16+
"php": "^8.5",
1717
"ext-dom": "*",
1818

1919
"simplesamlphp/assert": "~2.0",
20-
"simplesamlphp/saml2": "~6.1",
21-
"simplesamlphp/xml-common": "~2.8"
20+
"simplesamlphp/saml2": "dev-feature/dom-migration-php84",
21+
"simplesamlphp/xml-common": "dev-feature/dom-migration-php84"
2222
},
2323
"require-dev": {
2424
"simplesamlphp/simplesamlphp-test-framework": "~1.11"
@@ -33,6 +33,11 @@
3333
"SimpleSAML\\SPID\\": "tests/SPID/"
3434
}
3535
},
36+
"extra": {
37+
"branch-alias": {
38+
"dev-master": "v2.0.x-dev"
39+
}
40+
},
3641
"config": {
3742
"allow-plugins": {
3843
"composer/package-versions-deprecated": true,

src/SPID/XML/saml/Issuer.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
namespace SimpleSAML\SPID\XML\saml;
66

7-
use DOMElement;
7+
use Dom;
88
use SimpleSAML\Assert\Assert;
99
use SimpleSAML\SAML2\Constants as C;
1010
use SimpleSAML\SAML2\Type\SAMLAnyURIValue;
@@ -36,12 +36,12 @@ public function __construct(
3636
/**
3737
* Convert XML into an Issuer
3838
*
39-
* @param \DOMElement $xml The XML element we should load
39+
* @param \Dom\Element $xml The XML element we should load
4040
*
4141
* @return static
4242
* @throws \SimpleSAML\XMLSchema\Exception\InvalidDOMElementException
4343
*/
44-
public static function fromXML(DOMElement $xml): static
44+
public static function fromXML(Dom\Element $xml): static
4545
{
4646
Assert::same($xml->localName, 'Issuer', InvalidDOMElementException::class);
4747
Assert::same($xml->namespaceURI, Issuer::NS, InvalidDOMElementException::class);

0 commit comments

Comments
 (0)