Optional ext-soap

Author: tvdijen

.github/workflows/php.yml

@@ -78,7 +78,6 @@ jobs:
         run: composer install --no-progress --prefer-dist --optimize-autoloader
 
       - name: Check code for hard dependencies missing in composer.json
-        continue-on-error: true
         run: composer-require-checker check --config-file=tools/composer-require-checker.json composer.json
 
       - name: Check code for unused dependencies in composer.json

composer.json

@@ -24,7 +24,6 @@
         "ext-filter": "*",
         "ext-openssl": "*",
         "ext-pcre": "*",
-        "ext-soap": "*",
         "ext-zlib": "*",
 
         "nyholm/psr7": "^1.8",
@@ -36,6 +35,9 @@
         "simplesamlphp/xml-security": "~1.13.0",
         "simplesamlphp/xml-soap": "~1.7.0"
     },
+    "suggest": {
+        "ext-soap": "*"
+    },
     "require-dev": {
         "ext-intl": "*",
 

tools/composer-require-checker.json

@@ -1,5 +1,8 @@
 {
   "symbol-whitelist": [
+    "SoapClient",
+    "SOAP_1_1",
+    "SimpleSAML\\XMLSecurity\\XMLSecurityKey",
     "SimpleSAML\\Configuration",
     "SimpleSAML\\Error\\BadRequest",
     "SimpleSAML\\Error\\Error",