Fix several phpstan-issues

Author: tvdijen

phpstan.neon

@@ -1,4 +1,4 @@
 parameters:
-  level: 1
+  level: 2
   paths:
     - src

src/Type/CIDRValue.php

@@ -14,7 +14,7 @@ class CIDRValue extends SAMLStringValue
     /**
      * Validate the content of the element.
      *
-     * @param string $content  The value to go in the XML textContent
+     * @param string $value  The value to go in the XML textContent
      * @throws \Exception on failure
      * @return void
      */

src/Type/DomainValue.php

@@ -32,7 +32,7 @@ protected function sanitizeValue(string $value): string
     /**
      * Validate the content of the element.
      *
-     * @param string $content  The value to go in the XML textContent
+     * @param string $value  The value to go in the XML textContent
      * @throws \Exception on failure
      * @return void
      */

src/Type/EmailAddressValue.php

@@ -32,7 +32,7 @@ protected function sanitizeValue(string $value): string
     /**
      * Validate the content of the element.
      *
-     * @param string $content  The value to go in the XML textContent
+     * @param string $value  The value to go in the XML textContent
      * @throws \Exception on failure
      * @return void
      */

src/Type/GeolocationValue.php

@@ -30,7 +30,7 @@ protected function sanitizeValue(string $value): string
     /**
      * Validate the content of the element.
      *
-     * @param string $content  The value to go in the XML textContent
+     * @param string $value  The value to go in the XML textContent
      * @return void
      */
     protected function validateValue(string $value): void

src/Type/KeyTypesValue.php

@@ -22,10 +22,10 @@ class KeyTypesValue extends SAMLStringValue
      * @throws \Exception on failure
      * @return void
      */
-    protected function validateValue(string $value): void
+    protected function validateValue(string $content): void
     {
         Assert::oneOf(
-            $this->sanitizeValue($value),
+            $this->sanitizeValue($content),
             array_column(KeyTypesEnum::cases(), 'value'),
             SchemaViolationException::class,
         );

src/Type/ListOfStringsValue.php

@@ -48,7 +48,7 @@ protected function validateValue(string $value): void
     /**
      * Convert an array of xs:string items into a mdui:ListOfStrings
      *
-     * @param array<\SimpleSAML\SAML2\Type\StringValue> $keywords
+     * @param array<\SimpleSAML\SAML2\Type\SAMLStringValue> $keywords
      * @return static
      */
     public static function fromArray(array $keywords): static
@@ -67,7 +67,7 @@ public static function fromArray(array $keywords): static
     /**
      * Convert this mdui:ListOfStrings to an array of xs:string items
      *
-     * @return array<\SimpleSAML\SAML2\Type\StringValue>
+     * @return array<\SimpleSAML\SAML2\Type\SAMLStringValue>
      */
     public function toArray(): array
     {

src/Utilities/ArrayCollection.php

@@ -54,7 +54,7 @@ public function get($key)
 
 
     /**
-     * @param \Closure $f
+     * @param \Closure $filterFunction
      *
      * @return ArrayCollection
      */

src/XML/idpdisc/DiscoveryResponse.php

@@ -52,13 +52,13 @@ public function __construct(
         SAMLAnyURIValue $binding,
         SAMLAnyURIValue $location,
         ?BooleanValue $isDefault = null,
-        ?SAMLAnyURIValue $unused = null,
+        ?SAMLAnyURIValue $responseLocation = null, // unused
         array $children = [],
         array $attributes = [],
     ) {
         Assert::same($binding->getValue(), C::BINDING_IDPDISC, ProtocolViolationException::class);
         Assert::null(
-            $unused,
+            $responseLocation,
             'The \'ResponseLocation\' attribute must be omitted for idpdisc:DiscoveryResponse.',
         );
         parent::__construct($index, $binding, $location, $isDefault, null, $children, $attributes);

src/XML/md/AbstractIndexedEndpointType.php

@@ -40,7 +40,7 @@ abstract class AbstractIndexedEndpointType extends AbstractEndpointType implemen
      * @param \SimpleSAML\SAML2\Type\SAMLAnyURIValue $binding
      * @param \SimpleSAML\SAML2\Type\SAMLAnyURIValue $location
      * @param \SimpleSAML\XML\Type\BooleanValue|null $isDefault
-     * @param \SimpleSAML\SAML2\Type\AnyURIValue|null $responseLocation
+     * @param \SimpleSAML\SAML2\Type\SAMLAnyURIValue|null $responseLocation
      * @param array $children
      * @param list<\SimpleSAML\XML\Attribute> $attributes
      */