Signatures in SAML messages SHOULD NOT contain transforms other than the enveloped signature transform or the exclusive canonicalization transforms

tvdijen · tvdijen · commit b28bb14672d2 · 2025-12-22T17:03:06.000+01:00
diff --git a/src/XML/SignableElementTrait.php b/src/XML/SignableElementTrait.php
@@ -63,8 +63,6 @@ public function sign(
         Assert::oneOf(
             $canonicalizationAlg,
             [
-                C::C14N_INCLUSIVE_WITH_COMMENTS,
-                C::C14N_INCLUSIVE_WITHOUT_COMMENTS,
                 C::C14N_EXCLUSIVE_WITH_COMMENTS,
                 C::C14N_EXCLUSIVE_WITHOUT_COMMENTS,
             ],

Original file line number	Diff line number	Diff line change
`@@ -63,8 +63,6 @@ public function sign(`
`63`	`63`	`Assert::oneOf(`
`64`	`64`	`$canonicalizationAlg,`
`65`	`65`	`[`
`66`		`- C::C14N_INCLUSIVE_WITH_COMMENTS,`
`67`		`- C::C14N_INCLUSIVE_WITHOUT_COMMENTS,`
`68`	`66`	`C::C14N_EXCLUSIVE_WITH_COMMENTS,`
`69`	`67`	`C::C14N_EXCLUSIVE_WITHOUT_COMMENTS,`
`70`	`68`	`],`