Bump node to v20 and update workflows to start a new branch

Author: tvdijen

.github/workflows/build-release.yml

@@ -1,5 +1,5 @@
 ---
-name: Build assets for SimpleSAMLphp 2.4
+name: Build assets for SimpleSAMLphp 2.5
 
 on:  # yamllint disable-line rule:truthy
   push:
@@ -9,13 +9,16 @@ on:  # yamllint disable-line rule:truthy
   workflow_dispatch:
 
 jobs:
-  quality:
-    name: Quality checks
+  pre-quality-cleanup:
+    name: 'Cleanup Code Base'
     runs-on: ['ubuntu-latest']
     if: ${{ github.event.commits[0].author.name != 'dependabot[bot]' }}
 
+    strategy:
+      fail-fast: false
+
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
         with:
           token: ${{ secrets.ASSETS_COMMIT_TOKEN }}
           ref: ${{ github.head_ref || github.ref_name }}
@@ -30,25 +33,27 @@ jobs:
         # Remove generated files; we can't lint them and we want to detect removed files during build
         run: find css/ webfonts/ icons/ js/ -type f -not -name '.gitkeep' -delete
 
-      - name: Lint Code Base
-        uses: super-linter/super-linter/slim@v8
-        env:
-          DEFAULT_BRANCH: ${{ github.head_ref || github.ref_name }}
-          # CSS Linter will choke on generated assets
-          IGNORE_GENERATED_FILES: true
-          FILTER_REGEX_EXCLUDE: '(css|js|webfonts|icons)/.*'
-          # To report GitHub Actions status checks
-          SAVE_SUPER_LINTER_OUTPUT: false
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          LINTER_RULES_PATH: 'tools/linters'
-          VALIDATE_ALL_CODEBASE: true
-          VALIDATE_CSS: true
-          VALIDATE_JAVASCRIPT_ES: true
-          VALIDATE_JSON: true
-          VALIDATE_MARKDOWN: true
-          VALIDATE_YAML: true
-          VALIDATE_GITHUB_ACTIONS: true
+  quality:
+    name: 'Lint Code Base'
+    strategy:
+      fail-fast: false
+
+    uses: simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_linter.yml@v1.10.0
+    with:
+      enable_eslinter: true
+      enable_jsonlinter: true
+      enable_stylelinter: false
+      enable_yamllinter: true
+
+  post-quality-wrapup:
+    name: 'Save cleaned and quality-checked Code Base'
+    runs-on: ['ubuntu-latest']
+    needs: quality
+
+    strategy:
+      fail-fast: false
 
+    steps:
       - name: Zip artifact for deployment
         run: |
           zip release.zip -r .
@@ -62,7 +67,7 @@ jobs:
   build:
     name: Build assets
     runs-on: ['ubuntu-latest']
-    needs: quality
+    needs: post-quality-wrapup
 
     outputs:
       files_changed: ${{ steps.changes.outputs.files_changed }}

.github/workflows/update-dependencies.yml

@@ -1,5 +1,5 @@
 ---
-name: Update dependencies for SimpleSAMLphp 2.4
+name: Update dependencies for SimpleSAMLphp 2.5
 
 on: workflow_dispatch
 
@@ -13,7 +13,7 @@ jobs:
       packages_changed: ${{ steps.changes.outputs.packages_changed }}
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
         with:
           token: ${{ secrets.ASSETS_COMMIT_TOKEN }}
           ref: ${{ github.head_ref || github.ref_name }}

composer.json

@@ -10,9 +10,9 @@
         }
     ],
     "require": {
-        "php": "^8.1",
+        "php": "^8.2",
 
-        "simplesamlphp/composer-module-installer": "^1.3.4"
+        "simplesamlphp/composer-module-installer": "^1.4.0"
     },
     "archive": {
         "exclude": [

tools/linters/eslint.config.js

@@ -0,0 +1,19 @@
+// eslint.config.js
+const { defineConfig } = require("eslint/config");
+
+module.exports = defineConfig([
+    {
+        ignores: ["!/tools/linters/.eslint.config.js", "!/tools/linters/.stylelintrc.json"],
+        languageOptions: {
+            ecmaVersion: 2015,
+            sourceType: "module"
+        },
+        files: [
+            "**/*.js",
+        ],
+        rules: {
+            semi: "error",
+            "prefer-const": "error"
+        }
+    }
+]);