Move assert

tvdijen · tvdijen · commit 964571150a7d · 2019-09-24T15:24:13.000+02:00
diff --git a/lib/SAML2/XML/fed/SecurityTokenServiceType.php b/lib/SAML2/XML/fed/SecurityTokenServiceType.php
@@ -46,12 +46,12 @@ public function __construct(\DOMElement $xml = null)
      */
     public function toXML(\DOMElement $parent)
     {
-        assert(is_string($this->Location));
-
         if (is_null($this->Location)) {
             throw new \Exception('Location not set');
         }
 
+        assert(is_string($this->Location));
+
         $e = parent::toXML($parent);
         $e->setAttributeNS('http://www.w3.org/2000/xmlns/', 'xmlns:fed', Constants::NS_FED);
         $e->setAttributeNS(\SAML2\Constants::NS_XSI, 'xsi:type', 'fed:SecurityTokenServiceType');

Original file line number	Diff line number	Diff line change
`@@ -46,12 +46,12 @@ public function __construct(\DOMElement $xml = null)`
`46`	`46`	`*/`
`47`	`47`	`public function toXML(\DOMElement $parent)`
`48`	`48`	`{`
`49`		`- assert(is_string($this->Location));`
`50`		`-`
`51`	`49`	`if (is_null($this->Location)) {`
`52`	`50`	`throw new \Exception('Location not set');`
`53`	`51`	`}`
`54`	`52`
	`53`	`+ assert(is_string($this->Location));`
	`54`	`+`
`55`	`55`	`$e = parent::toXML($parent);`
`56`	`56`	`$e->setAttributeNS('http://www.w3.org/2000/xmlns/', 'xmlns:fed', Constants::NS_FED);`
`57`	`57`	`$e->setAttributeNS(\SAML2\Constants::NS_XSI, 'xsi:type', 'fed:SecurityTokenServiceType');`