Fix CI

Author: tvdijen

.github/workflows/php.yml

@@ -117,7 +117,7 @@ jobs:
         with:
           php-version: ${{ matrix.php-versions }}
           extensions: ctype, date, dom, fileinfo, filter, hash, intl, mbstring, openssl, pcre, posix,\
-            session, sodium, spl, xml
+            session, sodium, spl, xml, zip
           tools: composer
           ini-values: error_reporting=E_ALL
           coverage: none

src/Auth/Source/YubiKey.php

@@ -39,18 +39,19 @@ class YubiKey extends Auth\Source
     /**
      * The string used to identify our states.
      */
-    public const STAGEID = '\SimpleSAML\Module\authYubiKey\Auth\Source\YubiKey.state';
+    public const string STAGEID = '\SimpleSAML\Module\authYubiKey\Auth\Source\YubiKey.state';
 
     /**
      * The number of characters of the OTP that is the secure token.
      * The rest is the user id.
      */
-    public const TOKENSIZE = 32;
+    public const int TOKENSIZE = 32;
 
     /**
      * The key of the AuthId field in the state.
      */
-    public const AUTHID = '\SimpleSAML\Module\authYubiKey\Auth\Source\YubiKey.AuthId';
+    public const string AUTHID = '\SimpleSAML\Module\authYubiKey\Auth\Source\YubiKey.AuthId';
+
 
     /**
      * The client id/key for use with the Auth_Yubico PHP module.

tests/src/Controller/YubikeyTest.php

@@ -63,7 +63,9 @@ public function testOtpNoState(): void
         $c = new Controller\Yubikey($this->config, $this->session);
 
         $this->expectException(Error\BadRequest::class);
-        $this->expectExceptionMessage("BADREQUEST('%REASON%' => 'Missing AuthState parameter.')");
+        $this->expectExceptionMessage(
+            '{"errorCode":"BADREQUEST","%REASON%":"Missing AuthState parameter."}',
+        );
 
         $c->main($request);
     }
@@ -110,6 +112,7 @@ public function __construct(array $info, array $config)
             {
             }
 
+
             public static function handleLogin(string $authStateId, string $otp): ?string
             {
                 return 'WRONGUSERPASS';