Migrate to cas-lib #112
php.yml
on: pull_request
Matrix: PHP-Linter
Linter
/
ecmascript-linter
Linter
/
json-linter
Linter
/
style-linter
Linter
/
yaml-linter
Matrix: unit-tests-linux
Matrix: unit-tests-windows
Cleanup artifacts
3s
Annotations
20 errors and 5 warnings
|
UnusedIssueHandlerSuppression:
psalm-dev.xml#L0
/home/runner/work/simplesamlphp-module-cas/simplesamlphp-module-cas/psalm-dev.xml:0:0: UnusedIssueHandlerSuppression: Suppressed issue type "UnresolvableInclude" for /tests/bootstrap.php was not thrown. (see https://psalm.dev/326)
|
|
MissingOverrideAttribute:
tests/src/Controller/CASTest.php#L195
tests/src/Controller/CASTest.php:195:21: MissingOverrideAttribute: Method SimpleSAML\Test\Module\cas\Controller\_home_runner_work_simplesamlphp_module_cas_simplesamlphp_module_cas_tests_src_Controller_CASTest_php_190_5080::finalstep should have the "Override" attribute (see https://psalm.dev/358)
|
|
MissingOverrideAttribute:
tests/src/Controller/CASTest.php#L188
tests/src/Controller/CASTest.php:188:13: MissingOverrideAttribute: Method SimpleSAML\Test\Module\cas\Controller\_home_runner_work_simplesamlphp_module_cas_simplesamlphp_module_cas_tests_src_Controller_CASTest_php_177_4703::getbyid should have the "Override" attribute (see https://psalm.dev/358)
|
|
MissingOverrideAttribute:
tests/src/Controller/CASTest.php#L183
tests/src/Controller/CASTest.php:183:13: MissingOverrideAttribute: Method SimpleSAML\Test\Module\cas\Controller\_home_runner_work_simplesamlphp_module_cas_simplesamlphp_module_cas_tests_src_Controller_CASTest_php_177_4703::authenticate should have the "Override" attribute (see https://psalm.dev/358)
|
|
MissingOverrideAttribute:
tests/src/Controller/CASTest.php#L172
tests/src/Controller/CASTest.php:172:13: MissingOverrideAttribute: Method SimpleSAML\Test\Module\cas\Controller\_home_runner_work_simplesamlphp_module_cas_simplesamlphp_module_cas_tests_src_Controller_CASTest_php_171_4442::loadstate should have the "Override" attribute (see https://psalm.dev/358)
|
|
UnusedVariable:
tests/src/Controller/CASTest.php#L152
tests/src/Controller/CASTest.php:152:9: UnusedVariable: $result is never referenced or the value is not used (see https://psalm.dev/077)
|
|
MissingOverrideAttribute:
tests/src/Controller/CASTest.php#L144
tests/src/Controller/CASTest.php:144:13: MissingOverrideAttribute: Method SimpleSAML\Test\Module\cas\Controller\_home_runner_work_simplesamlphp_module_cas_simplesamlphp_module_cas_tests_src_Controller_CASTest_php_143_3578::loadstate should have the "Override" attribute (see https://psalm.dev/358)
|
|
MissingOverrideAttribute:
tests/src/Controller/CASTest.php#L115
tests/src/Controller/CASTest.php:115:13: MissingOverrideAttribute: Method SimpleSAML\Test\Module\cas\Controller\_home_runner_work_simplesamlphp_module_cas_simplesamlphp_module_cas_tests_src_Controller_CASTest_php_114_2762::loadstate should have the "Override" attribute (see https://psalm.dev/358)
|
|
MissingOverrideAttribute:
tests/src/Controller/CASTest.php#L34
tests/src/Controller/CASTest.php:34:5: MissingOverrideAttribute: Method SimpleSAML\Test\Module\cas\Controller\CASTest::setup should have the "Override" attribute (see https://psalm.dev/358)
|
|
UnusedClass:
tests/src/Controller/CASTest.php#L22
tests/src/Controller/CASTest.php:22:7: UnusedClass: Class SimpleSAML\Test\Module\cas\Controller\CASTest is never used (see https://psalm.dev/075)
|
|
MissingOverrideAttribute:
src/Auth/Source/CAS.php#L274
src/Auth/Source/CAS.php:274:5: MissingOverrideAttribute: Method SimpleSAML\Module\cas\Auth\Source\CAS::logout should have the "Override" attribute (see https://psalm.dev/358)
|
|
MissingOverrideAttribute:
src/Auth/Source/CAS.php#L247
src/Auth/Source/CAS.php:247:5: MissingOverrideAttribute: Method SimpleSAML\Module\cas\Auth\Source\CAS::authenticate should have the "Override" attribute (see https://psalm.dev/358)
|
|
UndefinedMethod:
src/Auth/Source/CAS.php#L171
src/Auth/Source/CAS.php:171:38: UndefinedMethod: Method DOMXPath::xpQuery does not exist (see https://psalm.dev/022)
|
|
TooFewArguments:
src/Auth/Source/CAS.php#L165
src/Auth/Source/CAS.php:165:22: TooFewArguments: Too few arguments for SimpleSAML\CAS\Utils\XPath::getXPath - expecting node to be passed (see https://psalm.dev/025)
|
|
PossiblyInvalidArgument:
src/Auth/Source/CAS.php#L161
src/Auth/Source/CAS.php:161:17: PossiblyInvalidArgument: Argument 3 of sprintf expects float|int|object{__tostring()}|string, but possibly different type SimpleSAML\CAS\Error|string provided (see https://psalm.dev/092)
|
|
PossiblyInvalidArrayAccess:
src/Auth/Source/CAS.php#L125
src/Auth/Source/CAS.php:125:21: PossiblyInvalidArrayAccess: Cannot access array value on non-array variable $res of type false (see https://psalm.dev/109)
|
|
PossiblyInvalidArrayAccess:
src/Auth/Source/CAS.php#L124
src/Auth/Source/CAS.php:124:20: PossiblyInvalidArrayAccess: Cannot access array value on non-array variable $res of type false (see https://psalm.dev/109)
|
|
MissingClassConstType:
src/Auth/Source/CAS.php#L43
src/Auth/Source/CAS.php:43:18: MissingClassConstType: Class constant "SimpleSAML\Module\cas\Auth\Source\CAS::AUTHID" should have a declared type. (see https://psalm.dev/359)
|
|
MissingClassConstType:
src/Auth/Source/CAS.php#L38
src/Auth/Source/CAS.php:38:18: MissingClassConstType: Class constant "SimpleSAML\Module\cas\Auth\Source\CAS::STAGE_INIT" should have a declared type. (see https://psalm.dev/359)
|
|
ClassMustBeFinal:
src/Auth/Source/CAS.php#L33
src/Auth/Source/CAS.php:33:7: ClassMustBeFinal: Class SimpleSAML\Module\cas\Auth\Source\CAS is never extended and is not part of the public API, and thus must be made final. (see https://psalm.dev/361)
|
|
PropertyNotSetInConstructor:
tests/src/Controller/CASTest.php#L28
tests/src/Controller/CASTest.php:28:27: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\cas\Controller\CASTest::$sourceConfig is not defined in constructor of SimpleSAML\Test\Module\cas\Controller\CASTest or in any private or final methods called in the constructor (see https://psalm.dev/074)
|
|
PropertyNotSetInConstructor:
tests/src/Controller/CASTest.php#L25
tests/src/Controller/CASTest.php:25:29: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\cas\Controller\CASTest::$config is not defined in constructor of SimpleSAML\Test\Module\cas\Controller\CASTest or in any private or final methods called in the constructor (see https://psalm.dev/074)
|
|
ClassMustBeFinal:
tests/src/Controller/CASTest.php#L22
tests/src/Controller/CASTest.php:22:7: ClassMustBeFinal: Class SimpleSAML\Test\Module\cas\Controller\CASTest is never extended and is not part of the public API, and thus must be made final. (see https://psalm.dev/361)
|
|
UnusedClass:
src/Controller/CAS.php#L23
src/Controller/CAS.php:23:7: UnusedClass: Class SimpleSAML\Module\cas\Controller\CAS is never used (see https://psalm.dev/075)
|
|
PossiblyUnusedMethod:
src/Auth/Source/CAS.php#L72
src/Auth/Source/CAS.php:72:21: PossiblyUnusedMethod: Cannot find any calls to method SimpleSAML\Module\cas\Auth\Source\CAS::__construct (see https://psalm.dev/087)
|