Skip to content

Commit 269cfbe

Browse files
authored
Remove UV to UP downgrade check (#103)
as per spec, UP and UV checks do not make reference to the original registration level, so this custom check is overdoing it. Since it also creates issues with some authenticators (Google Passkey manager at least), better to remove the check.
1 parent 974689a commit 269cfbe

1 file changed

Lines changed: 0 additions & 13 deletions

File tree

src/Controller/AuthProcess.php

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -163,19 +163,6 @@ public function main(Request $request): Response
163163
$debugEnabled,
164164
);
165165

166-
/** Custom check: if the token was initially registered with UV, but now
167-
* authenticates only UP, we don't allow this downgrade.
168-
*
169-
* This is not typically allowed by authenticator implementations anyway
170-
* (they typically require a full reset of the key to remove UV
171-
* protections) but to be safe: find out and tell user to re-enroll with
172-
* the lower security level. (level upgrades are of course OK.)
173-
*/
174-
if ($oneToken[5] > $authObject->getPresenceLevel()) {
175-
// phpcs:ignore Generic.Files.LineLength.TooLong
176-
throw new Exception("Token was initially registered with higher identification guarantees than now authenticated with (was: " . $oneToken[5] . " now " . $authObject->getPresenceLevel() . "!");
177-
}
178-
179166
// no matter what: if we are passwordless it MUST be presence-verified
180167
if (
181168
$state['FIDO2PasswordlessAuthMode'] === true &&

0 commit comments

Comments
 (0)