Skip to content

Commit 39918cd

Browse files
committed
Refactor method; return early when match is found
1 parent 24b506b commit 39918cd

1 file changed

Lines changed: 5 additions & 7 deletions

File tree

src/XML/DOMDocumentFactory.php

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -153,20 +153,18 @@ public static function normalizeDocument(Dom\XMLDocument $doc): Dom\XMLDocument
153153

154154
/**
155155
* @param \Dom\Element $elt
156-
* @param string $prefix
156+
* @param string|null $prefix
157157
*/
158-
public static function lookupNamespaceURI(Dom\Element $elt, string $prefix): ?string
158+
public static function lookupNamespaceURI(Dom\Element $elt, ?string $prefix): ?string
159159
{
160160
/** @var \Dom\NamespaceInfo[] $namespaces */
161161
$namespaces = $elt->ownerDocument->documentElement->getInScopeNamespaces();
162162

163163
$xmlnsAttributes = [];
164164
foreach ($namespaces as $ns) {
165-
$xmlnsAttributes[$ns->prefix] = $ns->namespaceURI;
166-
}
167-
168-
if (array_key_exists($prefix, $xmlnsAttributes)) {
169-
return $xmlnsAttributes[$prefix];
165+
if ($ns->prefix === $prefix) {
166+
return $ns->namespaceURI;
167+
}
170168
}
171169

172170
return null;

0 commit comments

Comments
 (0)