Use constant

Author: tvdijen

src/XML/Attribute.php

@@ -6,6 +6,7 @@
 
 use Dom;
 use SimpleSAML\XML\Assert\Assert;
+use SimpleSAML\XML\Constants as C;
 use SimpleSAML\XMLSchema\Type\Interface\ValueTypeInterface;
 use SimpleSAML\XMLSchema\Type\StringValue;
 
@@ -99,7 +100,7 @@ public function toXML(Dom\Element $parent): Dom\Element
     {
         if ($this->getNamespaceURI() !== null && !$parent->lookupPrefix($this->getNamespacePrefix())) {
             $parent->setAttributeNS(
-                'http://www.w3.org/2000/xmlns/',
+                C::NS_XMLNS,
                 'xmlns:' . $this->getNamespacePrefix(),
                 $this->getNamespaceURI(),
             );

src/XML/TypedTextContentTrait.php

@@ -6,6 +6,7 @@
 
 use Dom;
 use SimpleSAML\XML\Assert\Assert;
+use SimpleSAML\XML\Constants as C;
 use SimpleSAML\XMLSchema\Exception\InvalidDOMElementException;
 use SimpleSAML\XMLSchema\Exception\InvalidValueTypeException;
 use SimpleSAML\XMLSchema\Type\Interface\ValueTypeInterface;
@@ -101,7 +102,7 @@ public function toXML(?Dom\Element $parent = null): Dom\Element
         if ($this->getTextContentType() === QNameValue::class) {
             if (!$e->lookupPrefix($this->getContent()->getNamespaceURI()->getValue())) {
                 $e->setAttributeNS(
-                    'http://www.w3.org/2000/xmlns/',
+                    C::NS_XMLNS,
                     'xmlns:' . $this->getContent()->getNamespacePrefix()->getValue(),
                     $this->getContent()->getNamespaceURI()->getValue(),
                 );

tests/XPath/XPathTest.php

@@ -9,6 +9,7 @@
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
+use SimpleSAML\XML\Constants as C;
 use SimpleSAML\XML\DOMDocumentFactory;
 use SimpleSAML\XPath\XPath;
 
@@ -265,7 +266,7 @@ public function testXmlnsPrefixedDeclarationRegistersNamespaceViaAttributeBranch
         $doc->appendChild($root);
 
         // Add xmlns:foo on the root (attribute-branch should detect and register)
-        $root->setAttributeNS('http://www.w3.org/2000/xmlns/', 'xmlns:foo', 'https://example.org/foo');
+        $root->setAttributeNS(C::NS_XMLNS, 'xmlns:foo', 'https://example.org/foo');
 
         // Deep subtree that uses foo prefix but the context node itself is unprefixed
         $ctx = $doc->createElement('ctx');