Merge pull request #91 from ioigoume/feature/dom-migration-php84-ioigoume2

tvdijen · web-flow · commit 71d3e0d9dbc4 · 2026-06-03T20:13:58.000+02:00
feature/dom-migration-php84-ioigoume2
diff --git a/src/XML/DOMDocumentFactory.php b/src/XML/DOMDocumentFactory.php
@@ -97,7 +97,7 @@ static function (int $severity, string $message): never {
             restore_error_handler();
         }
 
-        foreach ($domDocument->childNodes as $child) {
+        foreach ($loaded->childNodes as $child) {
             Assert::false(
                 $child->nodeType === \XML_DOCUMENT_TYPE_NODE,
                 'Dangerous XML detected, DOCTYPE nodes are not allowed in the XML body',
@@ -245,7 +245,7 @@ public static function lookupNamespaceURI(Dom\Element $elt, ?string $prefix): ?s
         }
 
         /** @var \Dom\NamespaceInfo[] $namespaces */
-        $namespaces = $elt->ownerDocument->documentElement->getInScopeNamespaces();
+        $namespaces = $elt->getInScopeNamespaces();
 
         foreach ($namespaces as $ns) {
             if ($ns->prefix === $prefix) {

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ static function (int $severity, string $message): never {`
`97`	`97`	`restore_error_handler();`
`98`	`98`	`}`
`99`	`99`
`100`		`- foreach ($domDocument->childNodes as $child) {`
	`100`	`+ foreach ($loaded->childNodes as $child) {`
`101`	`101`	`Assert::false(`
`102`	`102`	`$child->nodeType === \XML_DOCUMENT_TYPE_NODE,`
`103`	`103`	`'Dangerous XML detected, DOCTYPE nodes are not allowed in the XML body',`
`@@ -245,7 +245,7 @@ public static function lookupNamespaceURI(Dom\Element $elt, ?string $prefix): ?s`
`245`	`245`	`}`
`246`	`246`
`247`	`247`	`/** @var \Dom\NamespaceInfo[] $namespaces */`
`248`		`- $namespaces = $elt->ownerDocument->documentElement->getInScopeNamespaces();`
	`248`	`+ $namespaces = $elt->getInScopeNamespaces();`
`249`	`249`
`250`	`250`	`foreach ($namespaces as $ns) {`
`251`	`251`	`if ($ns->prefix === $prefix) {`