Do not perform useless assertions.

Author: ioigoume

tests/XML/SchemaValidatableElementTraitTest.php

@@ -4,7 +4,7 @@
 
 namespace SimpleSAML\Test\XML;
 
-use DOMDocument;
+use PHPUnit\Framework\Attributes\DoesNotPerformAssertions;
 use PHPUnit\Framework\TestCase;
 use SimpleSAML\Test\Helper\Base64BinaryElement;
 use SimpleSAML\Test\Helper\BooleanElement;
@@ -20,14 +20,13 @@
  */
 final class SchemaValidatableElementTraitTest extends TestCase
 {
+    #[DoesNotPerformAssertions]
     public function testSchemaValidationPasses(): void
     {
         $file = 'tests/resources/xml/ssp_StringElement.xml';
         $chunk = DOMDocumentFactory::fromFile($file);
 
         $document = StringElement::schemaValidate($chunk);
-        // @phpstan-ignore-next-line
-        $this->assertInstanceOf(DOMDocument::class, $document);
     }
 
 

tests/XML/TypedTextContentTraitTest.php

@@ -4,6 +4,7 @@
 
 namespace SimpleSAML\Test\XML;
 
+use PHPUnit\Framework\Attributes\DoesNotPerformAssertions;
 use PHPUnit\Framework\TestCase;
 use SimpleSAML\Test\Helper\Base64BinaryElement;
 use SimpleSAML\Test\Helper\BooleanElement;
@@ -19,6 +20,7 @@
  */
 final class TypedTextContentTraitTest extends TestCase
 {
+    #[DoesNotPerformAssertions]
     public function testTypedContentPassesForString(): void
     {
         $file = 'tests/resources/xml/ssp_StringElement.xml';
@@ -27,11 +29,10 @@ public function testTypedContentPassesForString(): void
         $elt = $doc->documentElement;
 
         $stringElt = StringElement::fromXML($elt);
-        // @phpstan-ignore-next-line
-        $this->assertInstanceOf(StringElement::class, $stringElt);
     }
 
 
+    #[DoesNotPerformAssertions]
     public function testTypedContentPassesForBoolean(): void
     {
         $file = 'tests/resources/xml/ssp_BooleanElement.xml';
@@ -40,8 +41,6 @@ public function testTypedContentPassesForBoolean(): void
         $elt = $doc->documentElement;
 
         $stringElt = BooleanElement::fromXML($elt);
-        // @phpstan-ignore-next-line
-        $this->assertInstanceOf(BooleanElement::class, $stringElt);
     }