Support symfony/finder:^7.1 alongside ~6.4.0#63
Support symfony/finder:^7.1 alongside ~6.4.0#63donquixote wants to merge 3 commits intosimplesamlphp:masterfrom
Conversation
e0e3e95 to
245efb2
Compare
245efb2 to
dcd20f9
Compare
dcd20f9 to
b79fe59
Compare
|
As you could have read here, we're gonna wait on the LTS Symfony 7.4. |
That's ok. |
Btw the main difference to the other PR is that this one still allows Symfony 6.x, and also runs the tests with both. |
|
Sure we can, but we choose not to. Don't get me wrong, but this project runs on virtually no-one and we have to pick our battles. |
|
This might ease your pain a bit: #66 Tagged v2.0.1 I hope you can drop your fork now. |
9ab7bc6 to
3c65906
Compare
3ad4d24 to
64e4d31
Compare
|
Dependency got removed in v2.x of this library and will no longer be necessary as of SimpleSAMLphp 2.5 (end of this month or early next month) |
I found that all the tests still pass with symfony/finder:^7.3. (and possibly lower, I did not try.)
We need this because we want to use simplesamlphp with Drupal 11, which requires symfony/*:^7.3.
We are ok to use a fork for the time being, but it would be much better to have this in upstream.
I am not sure how dependabot will like this.
Also, we could discuss if we want
^6.4.0|^7.3instead of~6.4.0|^7.3for symfony/finder. With the~it won't allow6.5.*if/when that comes out.