Bugs

Author: tvdijen

src/XML/ds/Signature.php

@@ -153,7 +153,7 @@ public function getObjects(): array
      */
     protected function setObjects(array $objects): void
     {
-        Assert::allInstanceOf($objects, Chunk::class);
+        Assert::allIsInstanceOf($objects, Chunk::class);
 
         foreach ($objects as $o) {
             Assert::true(

tests/XML/ds/SignatureTest.php

@@ -6,8 +6,12 @@
 
 use PHPUnit\Framework\TestCase;
 use SimpleSAML\Test\XML\SerializableXMLTestTrait;
+use SimpleSAML\XML\Chunk;
 use SimpleSAML\XML\DOMDocumentFactory;
+use SimpleSAML\XMLSecurity\XML\ds\KeyInfo;
 use SimpleSAML\XMLSecurity\XML\ds\Signature;
+use SimpleSAML\XMLSecurity\XML\ds\SignatureValue;
+use SimpleSAML\XMLSecurity\XML\ds\SignedInfo;
 
 /**
  * Class \SimpleSAML\XMLSecurity\Test\XML\ds\SignatureTest

tests/resources/xml/ds_Signature.xml

@@ -21,7 +21,5 @@
     <ds:KeySomething>Some unknown tag within the ds-namespace</ds:KeySomething>
     <some>Chunk</some>
   </ds:KeyInfo>
-  <ds:Object>
-    <some>Chunk</some>
-  </ds:Object>
+  <ds:Object Id="abc123" MimeType="image/png" Encoding="http://www.w3.org/2000/09/xmldsig#base64">iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII=</ds:Object>
 </ds:Signature>