Fix

Author: tvdijen

src/XML/SignedElementInterface.php

@@ -29,7 +29,7 @@ public function getValidatingCertificates(): array;
      * but cannot be verified, an exception will be thrown.
      *
      * @param \SimpleSAML\XMLSecurity\XMLSecurityKey $key The key we should check against.
-     * @return bool True if successful, false if we don't have a signature that can be verified.
+     * @return \SimpleSAML\XMLSecurity\XML\SignedElementInterface The signed element if we can verify the signature.
      */
-    public function validate(XMLSecurityKey $key): bool;
+    public function validate(XMLSecurityKey $key): SignedElementInterface;
 }

src/XML/SignedElementTrait.php

@@ -7,6 +7,7 @@
 use Exception;
 use SimpleSAML\Assert\Assert;
 use SimpleSAML\XMLSecurity\XML\ds\Signature;
+use SimpleSAML\XMLSecurity\XML\SignedElementInterface;
 use SimpleSAML\XMLSecurity\XMLSecurityKey;
 
 /**
@@ -54,13 +55,13 @@ protected function setSignature(Signature $signature): void
      * validation fails.
      *
      * @param  \SimpleSAML\XMLSecurity\XMLSecurityKey $key The key we should check against.
-     * @return bool True on success, false when we don't have a signature.
+     * @return \SimpleSAML\XMLSecurity\XML\SignedElementInterface The Signed element if it was validated.
      * @throws \Exception
      */
-    public function validate(XMLSecurityKey $key): bool
+    public function validate(XMLSecurityKey $key): SignedElementInterface
     {
         if ($this->signature === null) {
-            return false;
+            throw new Exception("Unsigned element");
         }
 
         Assert::eq(
@@ -72,7 +73,7 @@ public function validate(XMLSecurityKey $key): bool
         // check the signature
         $signer = $this->signature->getSigner();
         if ($signer->verify($key) === 1) {
-            return true;
+            return /* This should return the signed element */;
         }
 
         throw new Exception("Unable to validate Signature");