Skip to content

Commit 9674d77

Browse files
authored
Improve workflow
1 parent 59df4de commit 9674d77

1 file changed

Lines changed: 4 additions & 11 deletions

File tree

.github/workflows/php.yml

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -54,17 +54,13 @@ jobs:
5454
- name: Install Composer dependencies
5555
run: composer install --no-progress --no-suggest --prefer-dist --optimize-autoloader
5656

57-
- name: Install test framework
58-
run: composer require simplesamlphp/simplesamlphp-test-framework --dev
59-
6057
- name: Syntax check PHP
6158
run: bash vendor/bin/check-syntax-php.sh
6259

6360
- name: Decide whether to run code coverage or not
64-
uses: allenevans/set-env@v1.0.0
6561
if: ${{ matrix.php-versions != '7.4' || matrix.operating-system != 'ubuntu-latest' }}
66-
with:
67-
NO_COVERAGE: "--no-coverage"
62+
run: |
63+
echo "NO_COVERAGE=--no-coverage" >> $GITHUB_ENV
6864
6965
- name: Run unit tests
7066
run: |
@@ -148,9 +144,6 @@ jobs:
148144
- name: Install Composer dependencies
149145
run: composer install --no-progress --no-suggest --prefer-dist --optimize-autoloader
150146

151-
- name: Install test framework
152-
run: composer require simplesamlphp/simplesamlphp-test-framework --dev
153-
154147
- name: Syntax check YAML / XML / JSON
155148
run: |
156149
bash vendor/bin/check-syntax-yaml.sh
@@ -198,11 +191,11 @@ jobs:
198191

199192
- name: PHP Code Sniffer
200193
continue-on-error: true
201-
run: php vendor/bin/phpcs src/
194+
run: php vendor/bin/phpcs
202195

203196
- name: Psalm
204197
continue-on-error: true
205-
uses: docker://vimeo/psalm-github-actions
198+
run: vendor/bin/psalm
206199

207200
- name: Psalter
208201
continue-on-error: true

0 commit comments

Comments
 (0)