Fix namespaces

Author: tvdijen

src/XML/ds/Signature.php

@@ -27,7 +27,7 @@ final class Signature extends AbstractDsElement
     /** @var string[] */
     protected array $certificates = [];
 
-    /** @var SignatureValue */
+    /** @var \SimpleSAML\XMLSecurity\XML\ds\SignatureValue */
     protected SignatureValue $value;
 
     /** @var \SimpleSAML\XMLSecurity\XMLSecurityKey|null */
@@ -41,6 +41,7 @@ final class Signature extends AbstractDsElement
      * Signature constructor.
      *
      * @param string $algorithm
+     * @param \SimpleSAML\XMLSecurity\XML\ds\SignatureValue $value
      * @param string[] $certificates
      * @param \SimpleSAML\XMLSecurity\XMLSecurityKey|null $key
      *
@@ -79,7 +80,7 @@ public function getAlgorithm(): string
      */
     protected function setAlgorithm(string $algorithm): void
     {
-        Assert::notEmpty($algorithm, 'Signature algorithm cannot be empty');
+        Assert::notWhitespaceOnly($algorithm, 'Signature algorithm cannot be empty');
         $this->algorithm = $algorithm;
     }
 
@@ -126,7 +127,7 @@ protected function setKey(?XMLSecurityKey $key): void
     /**
      * Get the SignatureValue corresponding to this signature.
      *
-     * @return SignatureValue
+     * @return \SimpleSAML\XMLSecurity\XML\ds\SignatureValue
      */
     public function getSignatureValue(): SignatureValue
     {
@@ -137,7 +138,7 @@ public function getSignatureValue(): SignatureValue
     /**
      * Set the SignatureValue.
      *
-     * @param SignatureValue $value
+     * @param \SimpleSAML\XMLSecurity\XML\ds\SignatureValue $value
      */
     protected function setSignatureValue(SignatureValue $value): void
     {
@@ -155,7 +156,7 @@ public function getSigner(): XMLSecurityDSig
 
 
     /**
-     * @param DOMElement $xml
+     * @param \DOMElement $xml
      *
      * @return \SimpleSAML\XML\AbstractXMLElement
      * @throws \Exception

src/XML/ds/SignatureValue.php

@@ -56,7 +56,7 @@ private function setValue(string $value): void
     /**
      * Convert XML into a SignatureValue
      *
-     * @param DOMElement $xml The XML element we should load
+     * @param \DOMElement $xml The XML element we should load
      * @return self
      *
      * @throws \SimpleSAML\XML\Exception\InvalidDOMElementException If the qualified name of the supplied element is
@@ -74,8 +74,8 @@ public static function fromXML(DOMElement $xml): object
     /**
      * Convert this SignatureValue to XML.
      *
-     * @param DOMElement|null $parent The element we should append this SignatureValue element to.
-     * @return DOMElement
+     * @param \DOMElement|null $parent The element we should append this SignatureValue element to.
+     * @return \DOMElement
      */
     public function toXML(DOMElement $parent = null): \DOMElement
     {
@@ -84,4 +84,4 @@ public function toXML(DOMElement $parent = null): \DOMElement
 
         return $e;
     }
-}
+}

tests/XML/ds/SignatureValueTest.php

@@ -10,7 +10,7 @@
 use SimpleSAML\XMLSecurity\XML\ds\SignatureValue;
 
 /**
- * Class \SimpleSAML\XMLSecurity\XML\ds\SignatureValue
+ * Class \SimpleSAML\XMLSecurity\XML\ds\SignatureValueTest
  *
  * @covers \SimpleSAML\XMLSecurity\XML\ds\AbstractDsElement
  * @covers \SimpleSAML\XMLSecurity\\XML\ds\SignatureValue