Signable elements should call toXML()

We got rid of the initial extra toSignedXML() method. If we want to sign an element, we should just call sign() on it, then get the result with toXML().

This means it will be toXML() the method that actually does the signing, while sign() will simply prepare everything for it and signal that the element should be signed when calling toXML().

Signed-off-by: Jaime Pérez <jaimepc@gmail.com>

Author: jaimeperez

src/XML/SignableElementInterface.php

@@ -27,7 +27,7 @@ public function getId(): ?string;
     /**
      * Sign the current element.
      *
-     * @note The signature will not be applied until toSignedXML() is called.
+     * @note The signature will not be applied until toXML() is called.
      *
      * @param \SimpleSAML\XMLSecurity\Alg\SignatureAlgorithm $signer The actual signer implementation to use.
      * @param string $canonicalizationAlg The identifier of the canonicalization algorithm to use.

src/XML/SignableElementTrait.php

@@ -60,7 +60,7 @@ abstract public function getId(): ?string;
     /**
      * Sign the current element.
      *
-     * @note The signature will not be applied until toSignedXML() is called.
+     * The signature will not be applied until toXML() is called.
      *
      * @param \SimpleSAML\XMLSecurity\Alg\SignatureAlgorithm $signer The actual signer implementation to use.
      * @param string $canonicalizationAlg The identifier of the canonicalization algorithm to use.