Merge pull request #164 from simpleweb/feature/fix-saga-example-types

Feature: Fix the types on the `RequestExample` saga

Author: craigcoles

.changeset/famous-buttons-shop.md

@@ -0,0 +1,5 @@
+---
+"romulus-cli": minor
+---
+
+Correctly types the RequestExample saga

generators/base/templates/App/Sagas/RequestExample.ts

@@ -1,26 +1,36 @@
-import { call, put, takeEvery } from 'redux-saga/effects';
-import API from '<%= name %>/App/Services/API';
+import { AxiosResponse, AxiosError } from "axios";
+import { call, put, takeEvery } from "redux-saga/effects";
+import API from "<%= name %>/App/Services/API";
 
-export const RequestExample = function*() {
-  try {
-
-    const url = 'https://reqres.in/api/users';
-    const result = yield call(API.get, url);
-    yield put({ type: 'REQUEST_EXAMPLE_SUCCESS', result });
-
-  } catch(error) {
+interface UsersResponse {
+  page: number;
+  per_page: number;
+  total_pages: number;
+  data: {
+    id: number;
+    email: string;
+    first_name: string;
+    last_name: string;
+    avatar: string;
+  }[];
+}
 
-    if (error.response) {
-      yield put({ type: 'REQUEST_EXAMPLE_ERROR', error });
+export const RequestExample = function* () {
+  try {
+    const url = "https://reqres.in/api/users";
+    const result: AxiosResponse<UsersResponse> = yield call(API.get, url);
+    yield put({ type: "REQUEST_EXAMPLE_SUCCESS", result });
+  } catch (error) {
+    if (error instanceof AxiosError && error.response) {
+      yield put({ type: "REQUEST_EXAMPLE_ERROR", error });
     } else {
-      yield put({ type: 'REQUEST_EXAMPLE_ERROR', error: 'Network error' });
+      yield put({ type: "REQUEST_EXAMPLE_ERROR", error: "Network error" });
     }
-
   }
-}
+};
 
-const watchRequestExample = function*() {
-  yield takeEvery('REQUEST_EXAMPLE', RequestExample);
-}
+const watchRequestExample = function* () {
+  yield takeEvery("REQUEST_EXAMPLE", RequestExample);
+};
 
 export default watchRequestExample;