Test: streams events tests#432
Open
zurekz wants to merge 5 commits into
Open
Conversation
Uriagat
reviewed
May 22, 2026
| auto event = eventHolder.value().get(); | ||
| if(event == nullptr || event->type != "streamRoomCreated") { | ||
| continue; | ||
| } |
Member
There was a problem hiding this comment.
triggerStreamRoomCreatedEvent schould create only "streamRoomCreated" Event, so if it create differt event test schould failed.
Uriagat
reviewed
May 22, 2026
| auto streamRoomId = createStreamRoomFor(user1, user2); | ||
| ScopeExit cleanup([&user2]() { user2.disconnect(); }); | ||
| subscribeForAllStreamEventQueries(user1, streamRoomId); | ||
| subscribeForAllStreamEventQueries(user2, streamRoomId); |
Member
There was a problem hiding this comment.
we should use fine grain subscription, ak subscribing only for event which we testing, to check: A) is subscription is working, B) it's gives us subscription that we want, C) any of other internal subscriptions don't leak to public API
Uriagat
reviewed
May 22, 2026
| auto streamRoomId = createStreamRoomFor(user1, user2); | ||
| ScopeExit cleanup([&user2]() { user2.disconnect(); }); | ||
| subscribeForAllStreamEventQueries(user1, streamRoomId); | ||
| subscribeForAllStreamEventQueries(user2, streamRoomId); |
Uriagat
reviewed
May 22, 2026
| auto streamRoomId = createStreamRoomFor(user1, user2); | ||
| ScopeExit cleanup([&user2]() { user2.disconnect(); }); | ||
| subscribeForAllStreamEventQueries(user1, streamRoomId); | ||
| subscribeForAllStreamEventQueries(user2, streamRoomId); |
Uriagat
reviewed
May 22, 2026
| auto streamRoomId = createStreamRoomFor(user1, user2); | ||
| ScopeExit cleanup([&user2]() { user2.disconnect(); }); | ||
| subscribeForAllStreamEventQueries(user1, streamRoomId); | ||
| subscribeForAllStreamEventQueries(user2, streamRoomId); |
Uriagat
reviewed
May 22, 2026
| auto streamRoomId = createStreamRoomFor(user1, user2); | ||
| ScopeExit cleanup([&user2]() { user2.disconnect(); }); | ||
| subscribeForAllStreamEventQueries(user1, streamRoomId); | ||
| subscribeForAllStreamEventQueries(user2, streamRoomId); |
Uriagat
reviewed
May 22, 2026
| auto streamRoomId = createStreamRoomFor(user1, user2); | ||
| ScopeExit cleanup([&user2]() { user2.disconnect(); }); | ||
| subscribeForAllStreamEventQueries(user1, streamRoomId); | ||
| subscribeForAllStreamEventQueries(user2, streamRoomId); |
Uriagat
reviewed
May 22, 2026
| auto streamRoomId = createStreamRoomFor(user1, user2); | ||
| ScopeExit cleanup([&user2]() { user2.disconnect(); }); | ||
| subscribeForAllStreamEventQueries(user1, streamRoomId); | ||
| subscribeForAllStreamEventQueries(user2, streamRoomId); |
Uriagat
reviewed
May 22, 2026
| auto streamRoomId = createStreamRoomFor(user1, user2); | ||
| ScopeExit cleanup([&user2]() { user2.disconnect(); }); | ||
| subscribeForAllStreamEventQueries(user1, streamRoomId); | ||
| subscribeForAllStreamEventQueries(user2, streamRoomId); |
Uriagat
reviewed
May 22, 2026
| auto streamRoomId = createStreamRoomFor(user1, user2); | ||
| ScopeExit cleanup([&user2]() { user2.disconnect(); }); | ||
| subscribeForAllStreamEventQueries(user1, streamRoomId); | ||
| subscribeForAllStreamEventQueries(user2, streamRoomId); |
Uriagat
reviewed
May 22, 2026
| TEST_F(StreamEventsTest, waitEvent_getEvent_streamRoomCreated_two_users) { | ||
| EXPECT_NO_THROW({ | ||
| eventQueue.waitEvent(); // pop fixture libConnected from queue | ||
| }); |
Member
There was a problem hiding this comment.
why you use it if you have function drainEventQueue()
Uriagat
reviewed
May 22, 2026
| continue; | ||
| } | ||
| auto event = eventHolder.value().get(); | ||
| if(event == nullptr || event->type != eventType) { |
Member
There was a problem hiding this comment.
when waiting for given event Type and you revive other event, you should minimum LOG unwanted event, but in most cases in test it should fails because it receives unwanted event on API site
Uriagat
requested changes
May 22, 2026
Uriagat
force-pushed
the
test/streams-events-tests
branch
from
11b01d7 to
aaa11ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.