feat(search): Block WAL file access in PrivmxExtFS to reduce server requests#443
Open
kisielewski wants to merge 1 commit into
Open
feat(search): Block WAL file access in PrivmxExtFS to reduce server requests#443kisielewski wants to merge 1 commit into
kisielewski wants to merge 1 commit into
Conversation
SQLite queries the VFS for WAL file existence on every read/write operation. Since the Search module does not use WAL mode, intercepting these calls in PrivmxExtFS::access() avoids unnecessary round-trips to the server.
djenczewski
approved these changes
Jun 3, 2026
Uriagat
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blockWalAccessflag toPrivmxExtFS(constructor parameter, defaults tofalse)PrivmxExtFS::access()now short-circuits withfalsefor paths ending in-walwhen the flag is setPrivmxExtFSwithblockWalAccess = trueMotivation
SQLite queries the VFS for WAL file existence on every read/write operation. Since the Search module does not use WAL mode, these calls were generating unnecessary round-trips to the server. This change intercepts them at the
PrivmxExtFSlevel, keeping the VFS layer clean.The
-shmfile is not a concern here — SQLite only checks for it after confirming the-walfile exists, so blocking-walaccess prevents any-shmlookups as well.The flag is intentionally placed in
PrivmxExtFSrather than the VFS layer to allow a future SQL module to register its own VFS with WAL support enabled.