INCIDENT-010: validate IP address and endpoints taken as a part of CRD fields#224
Open
boddumanohar wants to merge 3 commits into
Open
INCIDENT-010: validate IP address and endpoints taken as a part of CRD fields#224boddumanohar wants to merge 3 commits into
boddumanohar wants to merge 3 commits into
Conversation
boddumanohar
force-pushed
the
INCIDENT-010
branch
from
b5a9aa3 to
40ce14e
Compare
- Run make manifests generate to sync pattern validations for localEndpoint and HashiCorp Vault baseURL into the CRD YAML - Remove unused eventReasonClusterLookupError and eventReasonClusterAuthError constants flagged by golangci-lint
boddumanohar
force-pushed
the
INCIDENT-010
branch
from
a499364 to
37b2b93
Compare
noctarius
reviewed
Jun 19, 2026
noctarius
requested changes
Jun 23, 2026
| // (SSRF protection: RFC-1918, loopback, link-local, cloud IMDS, IPv6 equivalents). | ||
| var blockedIPNets = func() []*net.IPNet { | ||
| cidrs := []string{ | ||
| "10.0.0.0/8", |
Collaborator
There was a problem hiding this comment.
I still believe that the internal networks need to be removed from the list in this specific case since it's totally valid on self-hosted (and even hosted) clusters:
- 10.0.0.0/8 (actually Kubernetes default)
- 172.16.0.0/12
- 192.168.0.0/16
- fc00::/7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #189
created a function
ValidateExternalURLthat validations and blocks endpoints inblockedIPNetslist