Skip to content

Commit 13f711a

Browse files
mxsrcboddumanohar
authored andcommitted
Fix deployment workflow to avoid resolving vars
When using double quotations, values that contain bash instructions will attempt to be resolved, for example credentials using '$' symbols might be invalidated this way. This switches to single quotes for all inputs that are used directly, avoiding this issue.
1 parent c04480a commit 13f711a

1 file changed

Lines changed: 14 additions & 14 deletions

File tree

.github/workflows/_deploy.yml

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -60,26 +60,26 @@ jobs:
6060
# vars.DOMAIN holds the base domain for the current environment.
6161
[ -n "${{ vars.DOMAIN }}" ] && HELM_EXTRA_ARGS+=(--set-string "domainSuffix=${{ vars.DOMAIN }}")
6262
63-
helm upgrade --install "${{ inputs.deployment_name }}" ./chart \
64-
--namespace "${{ inputs.deployment_name }}" \
63+
helm upgrade --install '${{ inputs.deployment_name }}' ./chart \
64+
--namespace '${{ inputs.deployment_name }}' \
6565
--create-namespace \
6666
--wait \
6767
--timeout 10m \
68-
--set-string domain="${{ inputs.domain || vars.DOMAIN }}" \
68+
--set-string domain='${{ inputs.domain || vars.DOMAIN }}' \
6969
--set database.replicas=${{ inputs.environment == 'prod' && 3 || 1 }} \
7070
--set-string database.cpu="${{ inputs.environment == 'prod' && '1' || '500m' }}" \
7171
--set-string database.memory="${{ inputs.environment == 'prod' && '1Gi' || '0.5Gi' }}" \
7272
--set vector.useHostPath=${{ inputs.vector_host_path }} \
73-
--set-string controller.image.tag="${{ inputs.image_tag }}" \
74-
--set-string controller.env.VELA_DEPLOYMENT_NAMESPACE_PREFIX="${{ inputs.deployment_name }}" \
75-
--set-string controller.env.VELA_CLOUDFLARE_API_TOKEN="${{ secrets.VELA_CLOUDFLARE_API_TOKEN }}" \
76-
--set-string controller.env.VELA_CLOUDFLARE_ZONE_ID="${{ secrets.VELA_CLOUDFLARE_ZONE_ID }}" \
77-
--set-string controller.env.VELA_KEYCLOAK_ADMIN_NAME="${{ secrets.VELA_KEYCLOAK_ADMIN_NAME }}" \
78-
--set-string controller.env.VELA_KEYCLOAK_ADMIN_SECRET="${{ secrets.VELA_KEYCLOAK_ADMIN_SECRET }}" \
79-
--set-string controller.env.VELA_BRANCH_REF="${{ vars.VELA_BRANCH_REF }}" \
80-
--set-string controller.env.VELA_BRANCH_DB_REF="${{ vars.VELA_BRANCH_DB_REF }}" \
81-
--set-string controller.env.VELA_ENABLE_DB_EXTERNAL_IPV6_LOADBALANCER="${{ vars.ENABLE_DB_EXTERNAL_IPV6_LOADBALANCER }}" \
82-
--set-string controller.env.VELA_SIMPLYBLOCK_CSI_NAMESPACE="${{ vars.SIMPLYBLOCK_CSI_NAMESPACE }}" \
73+
--set-string controller.image.tag='${{ inputs.image_tag }}' \
74+
--set-string controller.env.VELA_DEPLOYMENT_NAMESPACE_PREFIX='${{ inputs.deployment_name }}' \
75+
--set-string controller.env.VELA_CLOUDFLARE_API_TOKEN='${{ secrets.VELA_CLOUDFLARE_API_TOKEN }}' \
76+
--set-string controller.env.VELA_CLOUDFLARE_ZONE_ID='${{ secrets.VELA_CLOUDFLARE_ZONE_ID }}' \
77+
--set-string controller.env.VELA_KEYCLOAK_ADMIN_NAME='${{ secrets.VELA_KEYCLOAK_ADMIN_NAME }}' \
78+
--set-string controller.env.VELA_KEYCLOAK_ADMIN_SECRET='${{ secrets.VELA_KEYCLOAK_ADMIN_SECRET }}' \
79+
--set-string controller.env.VELA_BRANCH_REF='${{ vars.VELA_BRANCH_REF }}' \
80+
--set-string controller.env.VELA_BRANCH_DB_REF='${{ vars.VELA_BRANCH_DB_REF }}' \
81+
--set-string controller.env.VELA_ENABLE_DB_EXTERNAL_IPV6_LOADBALANCER='${{ vars.ENABLE_DB_EXTERNAL_IPV6_LOADBALANCER }}' \
82+
--set-string controller.env.VELA_SIMPLYBLOCK_CSI_NAMESPACE='${{ vars.SIMPLYBLOCK_CSI_NAMESPACE }}' \
8383
--set-string studio.image.tag="${{ inputs.environment == 'prod' && 'latest' || 'dev' }}" \
84-
--set-string monitoring.VELA_GRAFANA_SECURITY_ADMIN_PASSWORD="${{ secrets.VELA_GRAFANA_SECURITY_ADMIN_PASSWORD }}" \
84+
--set-string monitoring.VELA_GRAFANA_SECURITY_ADMIN_PASSWORD='${{ secrets.VELA_GRAFANA_SECURITY_ADMIN_PASSWORD }}' \
8585
"${HELM_EXTRA_ARGS[@]}"

0 commit comments

Comments
 (0)