Open
Conversation
boddumanohar
force-pushed
the
set-iops-using-annotations
branch
from
d6e64a2 to
5c1349e
Compare
mxsrc
requested changes
Apr 2, 2026
Collaborator
mxsrc
left a comment
mxsrc
left a comment
There was a problem hiding this comment.
Instead of passing the constant into the storage-class parameters, we should remove those parameters altogether, there's no need for them anymore.
boddumanohar
force-pushed
the
set-iops-using-annotations
branch
from
ba16f22 to
7856714
Compare
mxsrc
requested changes
Apr 3, 2026
Collaborator
mxsrc
left a comment
mxsrc
left a comment
There was a problem hiding this comment.
Much better! There are a few open quesitions I added as comments. Additionally, there are unused functions now, in particular I spotted simplyblock.vela.deployment.kubernetes.{get,delete}_storage_class. There might be others, imho they can be removed, if we need this functionality in the future we can re-introduce it.
Comment on lines
+312
to
+341
| _, autoscaler_vm_name = get_autoscaler_vm_identity(branch_id) | ||
| pvc_names = ( | ||
| f"{autoscaler_vm_name}{AUTOSCALER_PVC_SUFFIX}", | ||
| f"{autoscaler_vm_name}{AUTOSCALER_WAL_PVC_SUFFIX}", | ||
| f"{autoscaler_vm_name}{STORAGE_PVC_SUFFIX}", | ||
| ) | ||
|
|
||
| async def _resolve_existing_volume(pvc_name: str) -> UUID | None: | ||
| try: | ||
| volume, _ = await _resolve_volume_identifiers(namespace, pvc_name) | ||
| except (VelaDeploymentError, VelaKubernetesError) as exc: | ||
| if "not found" in str(exc).lower(): | ||
| return None | ||
| raise | ||
| return volume | ||
|
|
||
| resolved_volumes = await asyncio.gather(*(_resolve_existing_volume(pvc_name) for pvc_name in pvc_names)) | ||
| volumes = tuple(dict.fromkeys(volume for volume in resolved_volumes if volume is not None)) | ||
| if not volumes: | ||
| raise VelaDeploymentError(f"Failed to resolve any Simplyblock volumes for branch {branch_id}") | ||
|
|
||
| volume, _ = await resolve_autoscaler_volume_identifiers(namespace) | ||
| try: | ||
| async with create_simplyblock_api() as sb_api: | ||
| await sb_api.update_volume(volume=volume, payload={"max_rw_iops": iops}) | ||
| await asyncio.gather( | ||
| *(sb_api.update_volume(volume=volume, payload={"max_rw_iops": iops}) for volume in volumes) | ||
| ) | ||
| except VelaSimplyblockAPIError as exc: | ||
| raise VelaDeploymentError("Failed to update volume") from exc | ||
|
|
||
| logger.info("Updated Simplyblock volume %s IOPS to %s", volume, iops) | ||
|
|
||
|
|
||
| async def ensure_branch_storage_class(branch_id: Identifier, *, iops: int) -> str: | ||
| storage_class_name = branch_storage_class_name(branch_id) | ||
| try: | ||
| await kube_service.get_storage_class(storage_class_name) | ||
| logger.info("StorageClass %s already exists; reusing", storage_class_name) | ||
| return storage_class_name | ||
| except VelaKubernetesError: | ||
| pass | ||
|
|
||
| base_storage_class = await kube_service.get_storage_class(SIMPLYBLOCK_CSI_STORAGE_CLASS) | ||
| storage_class_manifest = _build_storage_class_manifest( | ||
| storage_class_name=storage_class_name, | ||
| iops=iops, | ||
| base_storage_class=base_storage_class, | ||
| ) | ||
| await kube_service.apply_storage_class(storage_class_manifest) | ||
| return storage_class_name | ||
| logger.info("Updated Simplyblock volumes %s IOPS to %s", list(volumes), iops) |
Collaborator
There was a problem hiding this comment.
Two questions:
- Why are we going through the simplyblock API here? In other places annotations to the PVC are sufficient.
- If we do in fact have to go through the API, a helper to set the IOPS of a PVC would make this more readable.
| new_manifest.spec.storage_class_name = SIMPLYBLOCK_CSI_STORAGE_CLASS | ||
| if hasattr(new_manifest.spec, "storageClassName"): | ||
| new_manifest.spec.storageClassName = self.storage_class_name | ||
| new_manifest.spec.storageClassName = SIMPLYBLOCK_CSI_STORAGE_CLASS |
Collaborator
There was a problem hiding this comment.
Same here, why do we have to handle the different cases?
src/deployment/kubernetes/pvc.py
Outdated
| @@ -101,7 +99,7 @@ def build_pvc_manifest_from_existing( | |||
| access_modes = list(getattr(spec, "access_modes", None) or []) | |||
| storage_class_name = getattr(spec, "storage_class_name", None) or getattr(spec, "storageClassName", None) | |||
Collaborator
There was a problem hiding this comment.
Why are we checking snake case here? According to the docs only camel case is expected. These lines could be
storage_class_name = getattr(spec, "storageClassName", SIMPLYBLOCK_CSI_STORAGE_CLASS)
or just using the constant in all cases.
boddumanohar
force-pushed
the
set-iops-using-annotations
branch
from
7856714 to
011833c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: simplyblock/vela#310
PR simplyblock/simplyblock-csi#294 introduces setting IOPS values using annotations.
example:
simplybk/qos-rw-iops: "1000"This will essentially remove the need for having to create a storage class.
At the moment, for every branch we create a storage class. This to override the IOPS setting. Now that we can set the IOPS using annotation, there is no need to create a storage class.
But with this approach when a branch is cloned/restored it will use the
SIMPLYBLOCK_CSI_STORAGE_CLASSstorage class which doesn't have IOPS QOS set. So we explicitly callupdate_branch_volume_iopsTest cases: