Skip to content

Fix pgboucnerconfig#724

Open
boddumanohar wants to merge 1 commit intodevfrom
fix-pgboucnerconfig
Open

Fix pgboucnerconfig#724
boddumanohar wants to merge 1 commit intodevfrom
fix-pgboucnerconfig

Conversation

@boddumanohar
Copy link
Copy Markdown
Member

@boddumanohar boddumanohar commented Apr 13, 2026

Fixes: simplyblock/vela#315
PGBouncer configuration is stored at "{vmi_name}-config" and is present in pgbouncer.ini file of the same configmap.

"level": "INFO", "logger": "uvicorn.access", "message": "10.244.5.195:34246 - \"PATCH /organizations/01KP2P7J4VXA6ENZT7MWEXTS62/projects/01KP2P7W7WVHD22DKTFYPZDQBH/branches/01KP2P8HK4CTR0XS21JK14560X/pgbouncer-config HTTP/1.1\" 200"}

testing

have updated default pool size from UI

the API request was successfully

{"timestamp": "2026-04-13T05:53:33+0000", "level": "INFO", "logger": "uvicorn.access", "message": "10.244.5.195:34246 - \"PATCH /organizations/01KP2P7J4VXA6ENZT7MWEXTS62/projects/01KP2P7W7WVHD22DKTFYPZDQBH/branches/01KP2P8HK4CTR0XS21JK14560X/pgbouncer-config HTTP/1.1\" 200"}

and the configmap is also updated successfully.

    default_pool_size = 40

and the the response of https:///api/platform/organizations//projects//branches//pgbouncer

also shows the updated value

{
    "pgbouncer_enabled": true,
    "pool_mode": "transaction",
    "max_client_conn": 100,
    "default_pool_size": 40,
    "server_idle_timeout": 60,
    "server_lifetime": 600,
    "query_wait_timeout": 30,
    "reserve_pool_size": 0
}

additional notes

Tests failures are not related to the fix in this PR

tests/branches/test_start_stop.py::test_branch_stop FAILED               [ 97%]
tests/branches/test_start_stop.py::test_branch_start FAILED              [100%]

@boddumanohar boddumanohar changed the base branch from main to dev April 13, 2026 01:20
@boddumanohar boddumanohar marked this pull request as ready for review April 13, 2026 05:58
@boddumanohar boddumanohar requested a review from mxsrc April 13, 2026 05:58
@mxsrc
Copy link
Copy Markdown
Collaborator

mxsrc commented Apr 13, 2026

Two more things, two of the Tests fail, it shouldnt be related but you never know. Also, could you introduce a test that would have uncovered this fault earlier?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants