fix(lazyLoad): abort URL-sourced transition when lazy loaded states do not match the URL

When a URL matches a future state's prefix but nothing in the lazy
loaded module matches the full URL, retryTransition() delegates to
urlService.sync() but returned undefined, letting the original
transition resume and activate the deregistered .** placeholder,
superseding the otherwise() transition started by sync().

Return false after sync() to abort the original transition so the
sync()-initiated transition (e.g. the otherwise() rule) can complete.

Closes ui-router#850

Author: simshanith

src/hooks/lazyLoad.ts

@@ -54,8 +54,11 @@ const lazyLoadHook: TransitionHookFn = (transition: Transition) => {
       return router.stateService.target(state, params, transition.options());
     }
 
-    // No matching state found, so let .sync() choose the best non-state match/otherwise
+    // No matching state found, so let .sync() choose the best non-state match/otherwise.
+    // Abort the current transition; otherwise it continues towards the (now deregistered)
+    // future state placeholder and supersedes the transition started by sync().
     router.urlService.sync();
+    return false;
   }
 
   const promises = transition

test/lazyLoadSpec.ts

@@ -1,4 +1,4 @@
-import { UIRouter, TransitionService, StateService } from '../src/index';
+import { UIRouter, TransitionService, StateService, RejectType, Rejection } from '../src/index';
 
 import { StateRegistry } from '../src/state/stateRegistry';
 import { UrlRouter } from '../src/url/urlRouter';
@@ -298,6 +298,58 @@ describe('future state', function() {
     });
   });
 
+  describe('triggered by a URL sync that the lazy loaded states do not match', () => {
+    let lazyLoadCount: number;
+
+    beforeEach(() => {
+      lazyLoadCount = 0;
+      $state.defaultErrorHandler(() => {});
+      $registry.register({ name: 'notFound' });
+      $registry.register({
+        name: 'A.**',
+        url: '/a',
+        lazyLoad: () => {
+          lazyLoadCount++;
+          return Promise.resolve({ states: [{ name: 'A', url: '/a/:id' }] });
+        },
+      });
+    });
+
+    // Test for https://github.com/ui-router/core/issues/850
+    it('should activate the otherwise() rule instead of the deregistered placeholder', (done) => {
+      router.urlService.rules.otherwise({ state: 'notFound' });
+
+      router.urlService.url('/a/no/such/page');
+      router.urlService.sync();
+
+      $transitions.onSuccess({}, () => {
+        expect(lazyLoadCount).toBe(1);
+        expect($state.current.name).toBe('notFound');
+        expect($registry.get('A.**')).toBeFalsy();
+        done();
+      });
+    });
+
+    it('should abort the original transition to the deregistered placeholder', (done) => {
+      router.urlService.rules.otherwise({ state: 'notFound' });
+      const errors: { targetName: string; error: Rejection }[] = [];
+      $transitions.onError({}, (trans) => {
+        errors.push({ targetName: trans.targetState().name(), error: trans.error() });
+      });
+
+      // The url change is synced by the url listener
+      router.urlService.url('/a/no/such/page');
+
+      $transitions.onSuccess({}, () => {
+        expect(errors.length).toBe(1);
+        expect(errors[0].targetName).toBe('A.**');
+        expect(errors[0].error.type).toBe(RejectType.ABORTED);
+        expect($state.current.name).toBe('notFound');
+        done();
+      });
+    });
+  });
+
   describe('that resolves to multiple states', () => {
     let futureA, futureB;
     const lazyA = { name: 'A', url: '/a/:id', params: { id: 'default' } };