feat: expand Sentry error capture across plugin and dashboards

wgutmann · claude · wgutmann · commit 8a2c407fee62 · 2026-03-25T19:24:25.000-04:00
Switch deploy cron check-ins to DSN-based relay endpoint, capture
previously swallowed exceptions in dashboard WebSocket handlers, and
add SentrySdk.CaptureException calls to all plugin catch blocks.

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/deploy.ps1 b/deploy.ps1
@@ -420,6 +420,21 @@ $sentryAuthToken = if (-not [string]::IsNullOrWhiteSpace($env:SENTRY_AUTH_TOKEN)
                    else { $null }
 $sentryRelease = if (-not [string]::IsNullOrWhiteSpace($script:SimStewardPluginVersionDeployed)) { $script:SimStewardPluginVersionDeployed } else { $null }
 
+function Parse-SentryDsn {
+    param([string]$Dsn)
+    # https://<public_key>@<ingest_domain>/<project_id>
+    if ($Dsn -match '^https://([^@]+)@([^/]+)/(\d+)$') {
+        return @{
+            PublicKey     = $Matches[1]
+            IngestDomain  = $Matches[2]
+            ProjectId     = $Matches[3]
+        }
+    }
+    return $null
+}
+
+$script:sentryDsn = Parse-SentryDsn $env:SIMSTEWARD_SENTRY_DSN
+
 function Push-SentryApi {
     param([string]$Path, [hashtable]$Body)
     if ([string]::IsNullOrWhiteSpace($sentryAuthToken) -or [string]::IsNullOrWhiteSpace($sentryRelease)) { return }
@@ -436,12 +451,12 @@ function Push-SentryApi {
 
 function Push-SentryCheckIn {
     param([string]$MonitorSlug, [string]$Status, [string]$CheckInId)
-    if ([string]::IsNullOrWhiteSpace($sentryAuthToken)) { return $null }
+    if (-not $script:sentryDsn) { return $null }
     try {
-        $headers = @{ Authorization = "Bearer $sentryAuthToken"; 'Content-Type' = 'application/json' }
+        $baseUrl = "https://$($script:sentryDsn.IngestDomain)/api/$($script:sentryDsn.ProjectId)/cron/$MonitorSlug/$($script:sentryDsn.PublicKey)/"
+        $headers = @{ 'Content-Type' = 'application/json' }
         if ([string]::IsNullOrWhiteSpace($CheckInId)) {
-            # Initial check-in: POST with monitor_config for auto-creation
-            $url = "https://sentry.io/api/0/organizations/$sentryOrg/monitors/$MonitorSlug/checkins/"
+            # Initial check-in: POST with monitor_config for upsert/auto-creation
             $body = @{
                 status         = $Status
                 monitor_config = @{
@@ -452,7 +467,7 @@ function Push-SentryCheckIn {
                 }
             }
             $json = $body | ConvertTo-Json -Compress -Depth 5
-            $resp = Invoke-RestMethod -Uri $url -Method Post -Headers $headers -Body $json -ErrorAction Stop
+            $resp = Invoke-RestMethod -Uri $baseUrl -Method Post -Headers $headers -Body $json -ErrorAction Stop
             $newId = $resp.id
             Push-LokiEvent 'deploy_sentry_checkin' 'INFO' "Sentry cron check-in started: $MonitorSlug" @{
                 monitor_slug = $MonitorSlug
@@ -461,11 +476,11 @@ function Push-SentryCheckIn {
             }
             return $newId
         } else {
-            # Completion check-in: PUT to update existing
-            $url = "https://sentry.io/api/0/organizations/$sentryOrg/monitors/$MonitorSlug/checkins/$CheckInId/"
+            # Completion check-in: POST with check_in_id to update existing
+            $url = "${baseUrl}?check_in_id=$CheckInId"
             $body = @{ status = $Status }
             $json = $body | ConvertTo-Json -Compress -Depth 5
-            Invoke-RestMethod -Uri $url -Method Put -Headers $headers -Body $json -ErrorAction Stop | Out-Null
+            Invoke-RestMethod -Uri $url -Method Post -Headers $headers -Body $json -ErrorAction Stop | Out-Null
             Push-LokiEvent 'deploy_sentry_checkin' 'INFO' "Sentry cron check-in completed: $MonitorSlug ($Status)" @{
                 monitor_slug = $MonitorSlug
                 status       = $Status
@@ -489,17 +504,20 @@ if (-not [string]::IsNullOrWhiteSpace($sentryAuthToken) -and -not [string]::IsNu
     Push-SentryApi "releases/" @{
         version  = $sentryRelease
         projects = $sentryProjects
-        refs     = @(@{ repository = "simsteward/simhub-plugin"; commit = $fullSha })
+        ref      = $fullSha
     }
 
+    # URL-encode release version for path segments ('+' in SemVer breaks URLs)
+    $encodedRelease = [System.Uri]::EscapeDataString($sentryRelease)
+
     # Deploy: simhub-plugin (C# DLLs)
-    Push-SentryApi "releases/$sentryRelease/deploys/" @{
+    Push-SentryApi "releases/$encodedRelease/deploys/" @{
         environment = 'local'
         name        = 'simhub-plugin'
     }
 
     # Deploy: web-dashboards (all HTML/JS dashboards)
-    Push-SentryApi "releases/$sentryRelease/deploys/" @{
+    Push-SentryApi "releases/$encodedRelease/deploys/" @{
         environment = 'local'
         name        = 'web-dashboards'
     }
diff --git a/src/SimSteward.Dashboard/index.html b/src/SimSteward.Dashboard/index.html
@@ -799,7 +799,8 @@
       try { onMsg(JSON.parse(e.data)); }
       catch (err) { if (typeof Sentry !== 'undefined') Sentry.captureException(err); }
     };
-  } catch {
+  } catch (err) {
+    if (typeof Sentry !== 'undefined') Sentry.captureException(err);
     setWs('disconnected');
     setTimeout(connectWs, 3000);
   }
@@ -827,7 +828,8 @@
   try {
     ws.send(JSON.stringify(o));
     return true;
-  } catch {
+  } catch (err) {
+    if (typeof Sentry !== 'undefined') Sentry.captureException(err);
     return false;
   }
 }
diff --git a/src/SimSteward.Dashboard/replay-incident-index.html b/src/SimSteward.Dashboard/replay-incident-index.html
@@ -155,8 +155,9 @@
       setTimeout(connectWs, 3000);
     };
     ws.onerror = () => {};
-    ws.onmessage = (e) => { try { onMsg(JSON.parse(e.data)); } catch (_) {} };
-  } catch (_) {
+    ws.onmessage = (e) => { try { onMsg(JSON.parse(e.data)); } catch (err) { if (typeof Sentry !== 'undefined') Sentry.captureException(err); } };
+  } catch (err) {
+    if (typeof Sentry !== 'undefined') Sentry.captureException(err);
     setTimeout(connectWs, 3000);
   }
 }
diff --git a/src/SimSteward.Plugin/SimStewardPlugin.DataCaptureSuite.cs b/src/SimSteward.Plugin/SimStewardPlugin.DataCaptureSuite.cs
@@ -770,6 +770,7 @@ private void TickT0_Rewind()
             }
             catch (Exception ex)
             {
+                SentrySdk.CaptureException(ex);
                 _logger?.Warn("DataCaptureSuite T0 rewind: " + ex.Message);
             }
 
diff --git a/src/SimSteward.Plugin/SimStewardPlugin.cs b/src/SimSteward.Plugin/SimStewardPlugin.cs
@@ -218,6 +218,7 @@ private void OnLogWriteError(string eventType, Exception ex)
 
         private void WriteBroadcastError(string context, Exception ex)
         {
+            if (ex != null) SentrySdk.CaptureException(ex);
             if (string.IsNullOrEmpty(_pluginDataPath)) return;
             var path = Path.Combine(_pluginDataPath, "broadcast-errors.log");
             var line = DateTime.UtcNow.ToString("o") + " " + context + (ex != null ? " " + ex.Message : "") + Environment.NewLine;
@@ -659,6 +660,7 @@ private System.Collections.Generic.Dictionary<string, object> BuildCaptureIncide
                 }
                 catch (Exception ex)
                 {
+                    SentrySdk.CaptureException(ex);
                     var err = ex.Message ?? "replay_session_failed";
                     LogActionResult(action, arg, correlationId, false, err);
                     return (false, null, err);
@@ -712,6 +714,7 @@ private System.Collections.Generic.Dictionary<string, object> BuildCaptureIncide
                 }
                 catch (Exception ex)
                 {
+                    SentrySdk.CaptureException(ex);
                     var err = ex.Message ?? "replay_speed_failed";
                     LogActionResult(action, arg, correlationId, false, err);
                     return (false, null, err);
@@ -746,6 +749,7 @@ private System.Collections.Generic.Dictionary<string, object> BuildCaptureIncide
                 }
                 catch (Exception ex)
                 {
+                    SentrySdk.CaptureException(ex);
                     var err = ex.Message ?? "replay_seek_failed";
                     LogActionResult(action, arg, correlationId, false, err);
                     return (false, null, err);
@@ -780,6 +784,7 @@ private System.Collections.Generic.Dictionary<string, object> BuildCaptureIncide
                 }
                 catch (Exception ex)
                 {
+                    SentrySdk.CaptureException(ex);
                     var err = ex.Message ?? "replay_jump_failed";
                     LogActionResult(action, arg, correlationId, false, err);
                     return (false, null, err);
@@ -810,6 +815,7 @@ private System.Collections.Generic.Dictionary<string, object> BuildCaptureIncide
                 }
                 catch (Exception ex)
                 {
+                    SentrySdk.CaptureException(ex);
                     var err = ex.Message ?? "seek_to_incident_failed";
                     LogActionResult(action, arg, correlationId, false, err);
                     return (false, null, err);
@@ -843,6 +849,7 @@ private System.Collections.Generic.Dictionary<string, object> BuildCaptureIncide
                 }
                 catch (Exception ex)
                 {
+                    SentrySdk.CaptureException(ex);
                     LogActionResult(action, arg, correlationId, false, ex.Message);
                     return (false, null, ex.Message);
                 }
@@ -889,6 +896,7 @@ private System.Collections.Generic.Dictionary<string, object> BuildCaptureIncide
                 catch (Exception ex)
                 {
                     sw.Stop();
+                    SentrySdk.CaptureException(ex);
                     LogActionResult(action, arg, correlationId, false, ex.Message, BuildCaptureIncidentSupplement(parsed, sw.ElapsedMilliseconds));
                     return (false, null, ex.Message);
                 }
@@ -1070,6 +1078,7 @@ private void RefreshDependencyChecks()
                 }
                 catch (Exception ex)
                 {
+                    SentrySdk.CaptureException(ex);
                     _dashboardPingStatus = "Error: " + ex.Message;
                     // #region agent log
                     WriteAgentHttpDebug("H1,H3,H5", "dashboard_ping_error", new Dictionary<string, object>
@@ -1491,6 +1500,7 @@ public void End(PluginManager pluginManager)
                 }
                 catch (Exception ex)
                 {
+                    SentrySdk.CaptureException(ex);
                     _logger?.Warn($"iRacing SDK Stop failed: {ex.Message}");
                 }
                 _irsdk = null;

Original file line number	Diff line number	Diff line change
`@@ -799,7 +799,8 @@`
`799`	`799`	`try { onMsg(JSON.parse(e.data)); }`
`800`	`800`	`catch (err) { if (typeof Sentry !== 'undefined') Sentry.captureException(err); }`
`801`	`801`	`};`
`802`		`- } catch {`
	`802`	`+ } catch (err) {`
	`803`	`+ if (typeof Sentry !== 'undefined') Sentry.captureException(err);`
`803`	`804`	`setWs('disconnected');`
`804`	`805`	`setTimeout(connectWs, 3000);`
`805`	`806`	`}`
`@@ -827,7 +828,8 @@`
`827`	`828`	`try {`
`828`	`829`	`ws.send(JSON.stringify(o));`
`829`	`830`	`return true;`
`830`		`- } catch {`
	`831`	`+ } catch (err) {`
	`832`	`+ if (typeof Sentry !== 'undefined') Sentry.captureException(err);`
`831`	`833`	`return false;`
`832`	`834`	`}`
`833`	`835`	`}`
Original file line number	Diff line number	Diff line change
`@@ -155,8 +155,9 @@`
`155`	`155`	`setTimeout(connectWs, 3000);`
`156`	`156`	`};`
`157`	`157`	`ws.onerror = () => {};`
`158`		`- ws.onmessage = (e) => { try { onMsg(JSON.parse(e.data)); } catch (_) {} };`
`159`		`- } catch (_) {`
	`158`	`+ ws.onmessage = (e) => { try { onMsg(JSON.parse(e.data)); } catch (err) { if (typeof Sentry !== 'undefined') Sentry.captureException(err); } };`
	`159`	`+ } catch (err) {`
	`160`	`+ if (typeof Sentry !== 'undefined') Sentry.captureException(err);`
`160`	`161`	`setTimeout(connectWs, 3000);`
`161`	`162`	`}`
`162`	`163`	`}`
Original file line number	Diff line number	Diff line change
`@@ -770,6 +770,7 @@ private void TickT0_Rewind()`
`770`	`770`	`}`
`771`	`771`	`catch (Exception ex)`
`772`	`772`	`{`
	`773`	`+ SentrySdk.CaptureException(ex);`
`773`	`774`	`_logger?.Warn("DataCaptureSuite T0 rewind: " + ex.Message);`
`774`	`775`	`}`
`775`	`776`
Original file line number	Diff line number	Diff line change
`@@ -218,6 +218,7 @@ private void OnLogWriteError(string eventType, Exception ex)`
`218`	`218`
`219`	`219`	`private void WriteBroadcastError(string context, Exception ex)`
`220`	`220`	`{`
	`221`	`+ if (ex != null) SentrySdk.CaptureException(ex);`
`221`	`222`	`if (string.IsNullOrEmpty(_pluginDataPath)) return;`
`222`	`223`	`var path = Path.Combine(_pluginDataPath, "broadcast-errors.log");`
`223`	`224`	`var line = DateTime.UtcNow.ToString("o") + " " + context + (ex != null ? " " + ex.Message : "") + Environment.NewLine;`
`@@ -659,6 +660,7 @@ private System.Collections.Generic.Dictionary<string, object> BuildCaptureIncide`
`659`	`660`	`}`
`660`	`661`	`catch (Exception ex)`
`661`	`662`	`{`
	`663`	`+ SentrySdk.CaptureException(ex);`
`662`	`664`	`var err = ex.Message ?? "replay_session_failed";`
`663`	`665`	`LogActionResult(action, arg, correlationId, false, err);`
`664`	`666`	`return (false, null, err);`
`@@ -712,6 +714,7 @@ private System.Collections.Generic.Dictionary<string, object> BuildCaptureIncide`
`712`	`714`	`}`
`713`	`715`	`catch (Exception ex)`
`714`	`716`	`{`
	`717`	`+ SentrySdk.CaptureException(ex);`
`715`	`718`	`var err = ex.Message ?? "replay_speed_failed";`
`716`	`719`	`LogActionResult(action, arg, correlationId, false, err);`
`717`	`720`	`return (false, null, err);`
`@@ -746,6 +749,7 @@ private System.Collections.Generic.Dictionary<string, object> BuildCaptureIncide`
`746`	`749`	`}`
`747`	`750`	`catch (Exception ex)`
`748`	`751`	`{`
	`752`	`+ SentrySdk.CaptureException(ex);`
`749`	`753`	`var err = ex.Message ?? "replay_seek_failed";`
`750`	`754`	`LogActionResult(action, arg, correlationId, false, err);`
`751`	`755`	`return (false, null, err);`
`@@ -780,6 +784,7 @@ private System.Collections.Generic.Dictionary<string, object> BuildCaptureIncide`
`780`	`784`	`}`
`781`	`785`	`catch (Exception ex)`
`782`	`786`	`{`
	`787`	`+ SentrySdk.CaptureException(ex);`
`783`	`788`	`var err = ex.Message ?? "replay_jump_failed";`
`784`	`789`	`LogActionResult(action, arg, correlationId, false, err);`
`785`	`790`	`return (false, null, err);`
`@@ -810,6 +815,7 @@ private System.Collections.Generic.Dictionary<string, object> BuildCaptureIncide`
`810`	`815`	`}`
`811`	`816`	`catch (Exception ex)`
`812`	`817`	`{`
	`818`	`+ SentrySdk.CaptureException(ex);`
`813`	`819`	`var err = ex.Message ?? "seek_to_incident_failed";`
`814`	`820`	`LogActionResult(action, arg, correlationId, false, err);`
`815`	`821`	`return (false, null, err);`
`@@ -843,6 +849,7 @@ private System.Collections.Generic.Dictionary<string, object> BuildCaptureIncide`
`843`	`849`	`}`
`844`	`850`	`catch (Exception ex)`
`845`	`851`	`{`
	`852`	`+ SentrySdk.CaptureException(ex);`
`846`	`853`	`LogActionResult(action, arg, correlationId, false, ex.Message);`
`847`	`854`	`return (false, null, ex.Message);`
`848`	`855`	`}`
`@@ -889,6 +896,7 @@ private System.Collections.Generic.Dictionary<string, object> BuildCaptureIncide`
`889`	`896`	`catch (Exception ex)`
`890`	`897`	`{`
`891`	`898`	`sw.Stop();`
	`899`	`+ SentrySdk.CaptureException(ex);`
`892`	`900`	`LogActionResult(action, arg, correlationId, false, ex.Message, BuildCaptureIncidentSupplement(parsed, sw.ElapsedMilliseconds));`
`893`	`901`	`return (false, null, ex.Message);`
`894`	`902`	`}`
`@@ -1070,6 +1078,7 @@ private void RefreshDependencyChecks()`
`1070`	`1078`	`}`
`1071`	`1079`	`catch (Exception ex)`
`1072`	`1080`	`{`
	`1081`	`+ SentrySdk.CaptureException(ex);`
`1073`	`1082`	`_dashboardPingStatus = "Error: " + ex.Message;`
`1074`	`1083`	`// #region agent log`
`1075`	`1084`	`WriteAgentHttpDebug("H1,H3,H5", "dashboard_ping_error", new Dictionary<string, object>`
`@@ -1491,6 +1500,7 @@ public void End(PluginManager pluginManager)`
`1491`	`1500`	`}`
`1492`	`1501`	`catch (Exception ex)`
`1493`	`1502`	`{`
	`1503`	`+ SentrySdk.CaptureException(ex);`
`1494`	`1504`	`_logger?.Warn($"iRacing SDK Stop failed: {ex.Message}");`
`1495`	`1505`	`}`
`1496`	`1506`	`_irsdk = null;`