fix(knowledge): guard against empty createDocumentRecords result

waleedlatif1 · claude · waleedlatif1 · commit 1516b748d357 · 2026-03-17T17:33:37.000-07:00
Add safety check before accessing firstDocument to prevent TypeError
and data loss if createDocumentRecords unexpectedly returns empty.

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/apps/sim/app/api/knowledge/[id]/documents/upsert/route.ts b/apps/sim/app/api/knowledge/[id]/documents/upsert/route.ts
@@ -151,6 +151,10 @@ export async function POST(req: NextRequest, { params }: { params: Promise<{ id:
     }
 
     const firstDocument = createdDocuments[0]
+    if (!firstDocument) {
+      logger.error(`[${requestId}] createDocumentRecords returned empty array unexpectedly`)
+      return NextResponse.json({ error: 'Failed to create document record' }, { status: 500 })
+    }
 
     processDocumentsWithQueue(
       createdDocuments,

Original file line number	Diff line number	Diff line change
`@@ -151,6 +151,10 @@ export async function POST(req: NextRequest, { params }: { params: Promise<{ id:`
`151`	`151`	`}`
`152`	`152`
`153`	`153`	`const firstDocument = createdDocuments[0]`
	`154`	`+ if (!firstDocument) {`
	`155`	+ logger.error(`[${requestId}] createDocumentRecords returned empty array unexpectedly`)
	`156`	`+ return NextResponse.json({ error: 'Failed to create document record' }, { status: 500 })`
	`157`	`+ }`
`154`	`158`
`155`	`159`	`processDocumentsWithQueue(`
`156`	`160`	`createdDocuments,`