fix(webhooks): address PR review feedback

- Restore original fall-through behavior for generic requireAuth with no token
- Replace `any` params with proper types in processor helper functions
- Restore array-aware initializer in processTriggerFileOutputs

Author: waleedlatif1

apps/sim/background/webhook-execution.ts

@@ -68,7 +68,7 @@ async function processTriggerFileOutputs(
     return input
   }
 
-  const processed: Record<string, unknown> = {}
+  const processed: Record<string, unknown> | unknown[] = Array.isArray(input) ? [] : {}
 
   for (const [key, value] of Object.entries(input)) {
     const currentPath = path ? `${path}.${key}` : key

apps/sim/lib/webhooks/processor.ts

@@ -182,8 +182,8 @@ export async function handlePreLookupWebhookVerification(
  * Delegates to the provider handler registry.
  */
 export function handleProviderReachabilityTest(
-  webhookRecord: any,
-  body: any,
+  webhookRecord: { provider: string },
+  body: unknown,
   requestId: string
 ): NextResponse | null {
   const handler = getProviderHandler(webhookRecord?.provider)
@@ -195,7 +195,7 @@ export function handleProviderReachabilityTest(
  * Delegates to the provider handler registry.
  */
 export function formatProviderErrorResponse(
-  webhookRecord: any,
+  webhookRecord: { provider: string },
   error: string,
   status: number
 ): NextResponse {
@@ -207,9 +207,13 @@ export function formatProviderErrorResponse(
  * Check if a webhook event should be skipped based on provider-specific filtering.
  * Delegates to the provider handler registry.
  */
-export function shouldSkipWebhookEvent(webhookRecord: any, body: any, requestId: string): boolean {
+export function shouldSkipWebhookEvent(
+  webhookRecord: { provider: string; providerConfig?: Record<string, unknown> },
+  body: unknown,
+  requestId: string
+): boolean {
   const handler = getProviderHandler(webhookRecord.provider)
-  const providerConfig = (webhookRecord.providerConfig as Record<string, unknown>) || {}
+  const providerConfig = webhookRecord.providerConfig ?? {}
   return (
     handler.shouldSkipEvent?.({ webhook: webhookRecord, body, requestId, providerConfig }) ?? false
   )

apps/sim/lib/webhooks/providers/generic.ts

@@ -14,15 +14,11 @@ export const genericHandler: WebhookProviderHandler = {
   verifyAuth({ request, requestId, providerConfig }: AuthContext) {
     if (providerConfig.requireAuth) {
       const configToken = providerConfig.token as string | undefined
-      if (!configToken) {
-        return new NextResponse('Unauthorized - Authentication required but not configured', {
-          status: 401,
-        })
-      }
-
-      const secretHeaderName = providerConfig.secretHeaderName as string | undefined
-      if (!verifyTokenAuth(request, configToken, secretHeaderName)) {
-        return new NextResponse('Unauthorized - Invalid authentication token', { status: 401 })
+      if (configToken) {
+        const secretHeaderName = providerConfig.secretHeaderName as string | undefined
+        if (!verifyTokenAuth(request, configToken, secretHeaderName)) {
+          return new NextResponse('Unauthorized - Invalid authentication token', { status: 401 })
+        }
       }
     }