fix(serializer): default canonical modes construction

Author: icecrasher321

apps/sim/serializer/index.test.ts

@@ -683,34 +683,37 @@ describe('Serializer', () => {
       expect(slackBlock?.config.params.username).toBe('bot')
     })
 
-    it.concurrent('should fall back to legacy advancedMode when canonicalModes not set', () => {
-      const serializer = new Serializer()
+    it.concurrent(
+      'should fall back to legacy advancedMode for non-credential canonical groups when canonicalModes not set',
+      () => {
+        const serializer = new Serializer()
 
-      const block: any = {
-        id: 'slack-1',
-        type: 'slack',
-        name: 'Test Slack Block',
-        position: { x: 0, y: 0 },
-        advancedMode: true,
-        subBlocks: {
-          operation: { value: 'send' },
-          destinationType: { value: 'channel' },
-          channel: { value: 'general' },
-          manualChannel: { value: 'C1234567890' },
-          text: { value: 'Hello world' },
-          username: { value: 'bot' },
-        },
-        outputs: {},
-        enabled: true,
-      }
+        const block: any = {
+          id: 'slack-1',
+          type: 'slack',
+          name: 'Test Slack Block',
+          position: { x: 0, y: 0 },
+          advancedMode: true,
+          subBlocks: {
+            operation: { value: 'send' },
+            destinationType: { value: 'channel' },
+            channel: { value: 'general' },
+            manualChannel: { value: 'C1234567890' },
+            text: { value: 'Hello world' },
+            username: { value: 'bot' },
+          },
+          outputs: {},
+          enabled: true,
+        }
 
-      const serialized = serializer.serializeWorkflow({ 'slack-1': block }, [], {})
-      const slackBlock = serialized.blocks.find((b) => b.id === 'slack-1')
+        const serialized = serializer.serializeWorkflow({ 'slack-1': block }, [], {})
+        const slackBlock = serialized.blocks.find((b) => b.id === 'slack-1')
 
-      expect(slackBlock).toBeDefined()
-      expect(slackBlock?.config.params.channel).toBe('C1234567890')
-      expect(slackBlock?.config.params.manualChannel).toBeUndefined()
-    })
+        expect(slackBlock).toBeDefined()
+        expect(slackBlock?.config.params.channel).toBe('C1234567890')
+        expect(slackBlock?.config.params.manualChannel).toBeUndefined()
+      }
+    )
 
     it.concurrent('should use basic value by default when no mode specified', () => {
       const serializer = new Serializer()

apps/sim/serializer/index.ts

@@ -61,8 +61,9 @@ function shouldSerializeSubBlock(
     const group = canonicalId ? canonicalIndex.groupsById[canonicalId] : undefined
     if (group && isCanonicalPair(group)) {
       const mode =
-        canonicalModeOverrides?.[group.canonicalId] ??
-        (displayAdvancedOptions ? 'advanced' : resolveCanonicalMode(group, values))
+        canonicalModeOverrides?.[group.canonicalId] != null || !displayAdvancedOptions
+          ? resolveCanonicalMode(group, values, canonicalModeOverrides)
+          : 'advanced'
       const matchesMode =
         mode === 'advanced'
           ? group.advancedIds.includes(subBlockConfig.id)
@@ -374,8 +375,15 @@ export class Serializer {
 
     Object.values(canonicalIndex.groupsById).forEach((group) => {
       const { basicValue, advancedValue } = getCanonicalValues(group, params)
+      const hasExplicitOverride = canonicalModeOverrides?.[group.canonicalId] != null
       const pairMode =
-        canonicalModeOverrides?.[group.canonicalId] ?? (legacyAdvancedMode ? 'advanced' : 'basic')
+        hasExplicitOverride || !legacyAdvancedMode
+          ? resolveCanonicalMode(
+              group,
+              buildSubBlockValues(block.subBlocks),
+              canonicalModeOverrides
+            )
+          : 'advanced'
       const chosen = pairMode === 'advanced' ? advancedValue : basicValue
 
       const sourceIds = [group.basicId, ...group.advancedIds].filter(Boolean) as string[]

apps/sim/stores/workflows/utils.ts

@@ -3,6 +3,7 @@ import { v4 as uuidv4 } from 'uuid'
 import { DEFAULT_DUPLICATE_OFFSET } from '@/lib/workflows/autolayout/constants'
 import { getEffectiveBlockOutputs } from '@/lib/workflows/blocks/block-outputs'
 import { mergeSubblockStateWithValues } from '@/lib/workflows/subblocks'
+import { buildCanonicalIndex, isCanonicalPair } from '@/lib/workflows/subblocks/visibility'
 import { hasTriggerCapability } from '@/lib/workflows/triggers/trigger-utils'
 import { TriggerUtils } from '@/lib/workflows/triggers/triggers'
 import { getBlock } from '@/blocks'
@@ -196,6 +197,19 @@ export function prepareBlockState(options: PrepareBlockStateOptions): BlockState
     preferToolOutputs: !effectiveTriggerMode,
   })
 
+  if (blockConfig.subBlocks) {
+    const canonicalIndex = buildCanonicalIndex(blockConfig.subBlocks)
+    const canonicalModes: Record<string, 'basic' | 'advanced'> = {}
+    for (const group of Object.values(canonicalIndex.groupsById)) {
+      if (isCanonicalPair(group)) {
+        canonicalModes[group.canonicalId] = 'basic'
+      }
+    }
+    if (Object.keys(canonicalModes).length > 0) {
+      blockData.canonicalModes = canonicalModes
+    }
+  }
+
   return {
     id,
     type,