Skip to content

Commit 3ab3a0c

Browse files
committed
improvement(credentials): code cleanup
1 parent fc753a8 commit 3ab3a0c

169 files changed

Lines changed: 961 additions & 1126 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.claude/rules/sim-architecture.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ apps/
2929
└── realtime/ # Bun Socket.IO server (collaborative canvas)
3030
3131
packages/ # @sim/* — audit, auth, db, logger, realtime-protocol,
32-
# security, tsconfig, utils, workflow-authz,
32+
# security, tsconfig, utils, platform-authz,
3333
# workflow-persistence, workflow-types
3434
```
3535

.cursor/rules/sim-architecture.mdc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ apps/
2828
└── realtime/ # Bun Socket.IO server (collaborative canvas)
2929

3030
packages/ # @sim/* — audit, auth, db, logger, realtime-protocol,
31-
# security, tsconfig, utils, workflow-authz,
31+
# security, tsconfig, utils, platform-authz,
3232
# workflow-persistence, workflow-types
3333
```
3434

.cursor/rules/sim-testing.mdc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ These modules are mocked globally — do NOT re-mock them in test files unless y
2222
- `@/stores/console/store`, `@/stores/terminal`, `@/stores/execution/store`
2323
- `@/blocks/registry`
2424
- `@trigger.dev/sdk`
25-
- `@sim/workflow-authz` → `workflowAuthzMock`
25+
- `@sim/platform-authz/workflow` → `workflowAuthzMock`
2626

2727
## Structure
2828

.github/CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Thank you for your interest in contributing to Sim! Our goal is to provide devel
88
> - `apps/sim/` — the main Next.js application (App Router, ReactFlow, Zustand, Shadcn, Tailwind CSS).
99
> - `apps/realtime/` — a small Bun + Socket.IO server that powers the collaborative canvas. Shares DB and Better Auth secrets with `apps/sim` via `@sim/*` packages.
1010
> - `apps/docs/` — Fumadocs-based documentation site.
11-
> - `packages/` — shared workspace packages (`@sim/db`, `@sim/auth`, `@sim/audit`, `@sim/workflow-types`, `@sim/workflow-persistence`, `@sim/workflow-authz`, `@sim/realtime-protocol`, `@sim/security`, `@sim/logger`, `@sim/utils`, `@sim/testing`, `@sim/tsconfig`).
11+
> - `packages/` — shared workspace packages (`@sim/db`, `@sim/auth`, `@sim/audit`, `@sim/workflow-types`, `@sim/workflow-persistence`, `@sim/platform-authz`, `@sim/realtime-protocol`, `@sim/security`, `@sim/logger`, `@sim/utils`, `@sim/testing`, `@sim/tsconfig`).
1212
>
1313
> Strict one-way dependency flow: `apps/* → packages/*`. Packages never import from apps. Please ensure your contributions follow this and our best practices for clarity, maintainability, and consistency.
1414

AGENTS.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,11 @@ packages/
5151
├── auth/ # @sim/auth — shared Better Auth verifier
5252
├── db/ # @sim/db — drizzle schema + client
5353
├── logger/ # @sim/logger
54+
├── platform-authz/ # @sim/platform-authz — workspace + workflow authz (subpath exports)
5455
├── realtime-protocol/ # @sim/realtime-protocol — socket op constants + zod schemas
5556
├── security/ # @sim/security — safeCompare
5657
├── tsconfig/ # shared tsconfig presets
5758
├── utils/ # @sim/utils
58-
├── workflow-authz/ # @sim/workflow-authz
5959
├── workflow-persistence/ # @sim/workflow-persistence
6060
└── workflow-types/ # @sim/workflow-types — pure BlockState/Loop/Parallel types
6161
```
@@ -409,7 +409,7 @@ Use Vitest. Test files: `feature.ts` → `feature.test.ts`. See `.cursor/rules/s
409409

410410
### Global Mocks (vitest.setup.ts)
411411

412-
`@sim/db`, `@sim/db/schema`, `drizzle-orm`, `@sim/logger`, `@sim/workflow-authz`, `@/blocks/registry`, `@/lib/auth`, `@/lib/auth/hybrid`, `@/lib/core/utils/request`, `@trigger.dev/sdk`, and store mocks are provided globally. Do NOT re-mock them unless overriding behavior. (The `vi.mock('@/lib/auth', ...)` in the example below is an override of the global mock so `getSession` can be controlled per-test.)
412+
`@sim/db`, `@sim/db/schema`, `drizzle-orm`, `@sim/logger`, `@sim/platform-authz/workflow`, `@/blocks/registry`, `@/lib/auth`, `@/lib/auth/hybrid`, `@/lib/core/utils/request`, `@trigger.dev/sdk`, and store mocks are provided globally. Do NOT re-mock them unless overriding behavior. (The `vi.mock('@/lib/auth', ...)` in the example below is an override of the global mock so `getSession` can be controlled per-test.)
413413

414414
### Standard Test Pattern
415415

CLAUDE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,11 @@ packages/
5151
├── auth/ # @sim/auth — shared Better Auth verifier
5252
├── db/ # @sim/db — drizzle schema + client
5353
├── logger/ # @sim/logger
54+
├── platform-authz/ # @sim/platform-authz — workspace + workflow authz (subpath exports)
5455
├── realtime-protocol/ # @sim/realtime-protocol — socket op constants + zod schemas
5556
├── security/ # @sim/security — safeCompare
5657
├── tsconfig/ # shared tsconfig presets
5758
├── utils/ # @sim/utils
58-
├── workflow-authz/ # @sim/workflow-authz
5959
├── workflow-persistence/ # @sim/workflow-persistence
6060
└── workflow-types/ # @sim/workflow-types — pure BlockState/Loop/Parallel types
6161
```
@@ -409,7 +409,7 @@ Use Vitest. Test files: `feature.ts` → `feature.test.ts`. See `.cursor/rules/s
409409

410410
### Global Mocks (vitest.setup.ts)
411411

412-
`@sim/db`, `@sim/db/schema`, `drizzle-orm`, `@sim/logger`, `@sim/workflow-authz`, `@/blocks/registry`, `@/lib/auth`, `@/lib/auth/hybrid`, `@/lib/core/utils/request`, `@trigger.dev/sdk`, and store mocks are provided globally. Do NOT re-mock them unless overriding behavior. (The `vi.mock('@/lib/auth', ...)` in the example below is an override of the global mock so `getSession` can be controlled per-test.)
412+
`@sim/db`, `@sim/db/schema`, `drizzle-orm`, `@sim/logger`, `@sim/platform-authz/workflow`, `@/blocks/registry`, `@/lib/auth`, `@/lib/auth/hybrid`, `@/lib/core/utils/request`, `@trigger.dev/sdk`, and store mocks are provided globally. Do NOT re-mock them unless overriding behavior. (The `vi.mock('@/lib/auth', ...)` in the example below is an override of the global mock so `getSession` can be controlled per-test.)
413413

414414
### Standard Test Pattern
415415

apps/realtime/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@
2424
"@sim/auth": "workspace:*",
2525
"@sim/db": "workspace:*",
2626
"@sim/logger": "workspace:*",
27+
"@sim/platform-authz": "workspace:*",
2728
"@sim/realtime-protocol": "workspace:*",
2829
"@sim/security": "workspace:*",
2930
"@sim/utils": "workspace:*",
30-
"@sim/workflow-authz": "workspace:*",
3131
"@sim/workflow-persistence": "workspace:*",
3232
"@sim/workflow-types": "workspace:*",
3333
"@socket.io/redis-adapter": "8.3.0",

apps/realtime/src/database/operations.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import {
88
workflowSubflows,
99
} from '@sim/db'
1010
import { createLogger } from '@sim/logger'
11+
import { getActiveWorkflowContext } from '@sim/platform-authz/workflow'
1112
import {
1213
BLOCK_OPERATIONS,
1314
BLOCKS_OPERATIONS,
@@ -20,7 +21,6 @@ import {
2021
WORKFLOW_OPERATIONS,
2122
} from '@sim/realtime-protocol/constants'
2223
import { randomFloat } from '@sim/utils/random'
23-
import { getActiveWorkflowContext } from '@sim/workflow-authz'
2424
import { loadWorkflowFromNormalizedTablesRaw } from '@sim/workflow-persistence/load'
2525
import { mergeSubBlockValues } from '@sim/workflow-persistence/subblocks'
2626
import { isWorkflowBlockProtected } from '@sim/workflow-types/workflow'

apps/realtime/src/handlers/operations.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { createLogger } from '@sim/logger'
2+
import { assertWorkflowMutable, WorkflowLockedError } from '@sim/platform-authz/workflow'
23
import {
34
BLOCK_OPERATIONS,
45
BLOCKS_OPERATIONS,
@@ -11,7 +12,6 @@ import {
1112
import { WorkflowOperationSchema } from '@sim/realtime-protocol/schemas'
1213
import { getErrorMessage } from '@sim/utils/errors'
1314
import { generateId } from '@sim/utils/id'
14-
import { assertWorkflowMutable, WorkflowLockedError } from '@sim/workflow-authz'
1515
import { ZodError } from 'zod'
1616
import { persistWorkflowOperation } from '@/database/operations'
1717
import type { AuthenticatedSocket } from '@/middleware/auth'

apps/realtime/src/handlers/subblocks.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import { db } from '@sim/db'
22
import { workflow, workflowBlocks } from '@sim/db/schema'
33
import { createLogger } from '@sim/logger'
4+
import { assertWorkflowMutable, WorkflowLockedError } from '@sim/platform-authz/workflow'
45
import { SUBBLOCK_OPERATIONS } from '@sim/realtime-protocol/constants'
56
import { getErrorMessage } from '@sim/utils/errors'
6-
import { assertWorkflowMutable, WorkflowLockedError } from '@sim/workflow-authz'
77
import { isWorkflowBlockProtected } from '@sim/workflow-types/workflow'
88
import { and, eq } from 'drizzle-orm'
99
import type { AuthenticatedSocket } from '@/middleware/auth'

0 commit comments

Comments
 (0)