fix(search): log clipboard copy failures and make fuzzy positions read-only

- Copy workflow link now logs on clipboard write failure instead of silently
  swallowing the error, matching the sidebar's copy-link convention.
- FuzzyResult.positions is now readonly and the NO_MATCH singleton's array is
  frozen, so the shared instance can never be mutated by a caller.

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/components/command-items/command-items.tsx

@@ -16,7 +16,7 @@ interface Segment {
   hit: boolean
 }
 
-function buildSegments(text: string, positions: number[]): Segment[] {
+function buildSegments(text: string, positions: readonly number[]): Segment[] {
   const hits = new Set(positions)
   const segments: Segment[] = []
   for (let i = 0; i < text.length; i++) {

apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.tsx

@@ -1,6 +1,7 @@
 'use client'
 
 import { useCallback, useDeferredValue, useEffect, useMemo, useRef, useState } from 'react'
+import { createLogger } from '@sim/logger'
 import { Command } from 'cmdk'
 import { useParams, useRouter } from 'next/navigation'
 import { useTheme } from 'next-themes'
@@ -72,6 +73,8 @@ import type {
 } from './utils'
 import { filterAndSort } from './utils'
 
+const logger = createLogger('SearchModal')
+
 export type { SearchModalProps } from './utils'
 
 export function SearchModal({
@@ -257,7 +260,9 @@ export function SearchModal({
       icon: Link,
       context: 'workflow',
       run: () => {
-        navigator.clipboard.writeText(window.location.href).catch(() => {})
+        navigator.clipboard.writeText(window.location.href).catch((error) => {
+          logger.error('Failed to copy workflow link to clipboard', { error })
+        })
       },
     })
     list.push({

apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/utils.ts

@@ -112,11 +112,16 @@ export interface FuzzyResult {
   matched: boolean
   /** Relative ranking score; higher sorts first. Only meaningful when matched. */
   score: number
-  /** Indices into the candidate string that matched, ascending. */
-  positions: number[]
+  /** Indices into the candidate string that matched, ascending. Read-only. */
+  positions: readonly number[]
 }
 
-const NO_MATCH: FuzzyResult = { matched: false, score: 0, positions: [] }
+/**
+ * Shared singleton for the no-match case. The frozen empty array makes the
+ * read-only contract explicit and guarantees the shared instance can never be
+ * mutated by a caller.
+ */
+const NO_MATCH: FuzzyResult = { matched: false, score: 0, positions: Object.freeze([]) }
 
 function isCamelBoundary(text: string, index: number): boolean {
   if (index === 0) return false