simplify

Author: icecrasher321

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/starter/input-format.tsx

@@ -74,11 +74,6 @@ const BOOLEAN_OPTIONS: ComboboxOption[] = [
   { label: 'false', value: 'false' },
 ]
 
-/**
- * Creates a new field with default values
- */
-const createDefaultField = (): Field => createDefaultInputFormatField()
-
 /**
  * Validates and sanitizes field names by removing control characters and quotes
  */
@@ -127,7 +122,7 @@ export function FieldFormat({
    * the same id instead of a freshly generated one.
    */
   const fallbackFieldRef = useRef<Field | null>(null)
-  const fallbackField = (fallbackFieldRef.current ??= createDefaultField())
+  const fallbackField = (fallbackFieldRef.current ??= createDefaultInputFormatField())
 
   const value = isPreview ? previewValue : storeValue
   const fields: Field[] = Array.isArray(value) && value.length > 0 ? value : [fallbackField]
@@ -140,7 +135,7 @@ export function FieldFormat({
    */
   const addField = () => {
     if (isReadOnly) return
-    setStoreValue([...fields, createDefaultField()])
+    setStoreValue([...fields, createDefaultInputFormatField()])
   }
 
   /**
@@ -150,7 +145,7 @@ export function FieldFormat({
     if (isReadOnly) return
 
     if (fields.length === 1) {
-      setStoreValue([createDefaultField()])
+      setStoreValue([createDefaultInputFormatField()])
       return
     }
 

apps/sim/lib/workflows/input-format.test.ts

@@ -1,5 +1,6 @@
 import { describe, expect, it } from 'vitest'
 import {
+  createDefaultInputFormatField,
   extractInputFieldsFromBlocks,
   normalizeInputFormatValue,
 } from '@/lib/workflows/input-format'
@@ -227,3 +228,28 @@ describe('normalizeInputFormatValue', () => {
     expect(normalizeInputFormatValue(input)).toEqual(input)
   })
 })
+
+describe('createDefaultInputFormatField', () => {
+  it.concurrent('creates an empty field with the canonical default shape', () => {
+    const field = createDefaultInputFormatField()
+    expect(field).toEqual({
+      id: expect.any(String),
+      name: '',
+      type: 'string',
+      value: '',
+      collapsed: false,
+    })
+    expect(field.id.length).toBeGreaterThan(0)
+  })
+
+  it.concurrent('omits description so it is not persisted by default', () => {
+    expect('description' in createDefaultInputFormatField()).toBe(false)
+  })
+
+  it.concurrent('returns a fresh id and a new object on each call', () => {
+    const first = createDefaultInputFormatField()
+    const second = createDefaultInputFormatField()
+    expect(first.id).not.toBe(second.id)
+    expect(first).not.toBe(second)
+  })
+})

apps/sim/lib/workflows/input-format.ts

@@ -12,12 +12,11 @@ export interface WorkflowInputField {
 }
 
 /**
- * Stateful input-format field as stored in sub-block values.
- *
- * Extends the wire-level {@link InputFormatField} with the editor-only `id` and
- * `collapsed` fields maintained per row in the inputs editor.
+ * Stateful input-format field as stored in sub-block values: the editor's
+ * per-row shape, including the editor-only `id` and `collapsed` fields. Stricter
+ * than the wire-level {@link InputFormatField} (required `name`/`type`/`value`).
  */
-export interface InputFormatFieldState {
+interface InputFormatFieldState {
   id: string
   name: string
   type: 'string' | 'number' | 'boolean' | 'object' | 'array' | 'file[]'