Skip to content

Commit d6f369f

Browse files
committed
fix(grafana): trim dashboard/alert-rule UID in route URLs (carry over #5082)
PR #5082 added .trim() on dashboardUid/alertRuleUid in the original tool URL builders. Those tools now build their URLs in the internal routes, so apply the same trim there to preserve that behavior.
1 parent 69ec1ba commit d6f369f

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

apps/sim/app/api/tools/grafana/update_alert_rule/route.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export const POST = withRouteHandler(async (request: NextRequest) => {
6363
getHeaders['X-Grafana-Org-Id'] = params.organizationId
6464
}
6565

66-
const getUrl = `${baseUrl}/api/v1/provisioning/alert-rules/${params.alertRuleUid}`
66+
const getUrl = `${baseUrl}/api/v1/provisioning/alert-rules/${params.alertRuleUid.trim()}`
6767
const getValidation = await validateUrlWithDNS(getUrl, 'baseUrl')
6868
if (!getValidation.isValid || !getValidation.resolvedIP) {
6969
return NextResponse.json({
@@ -191,7 +191,7 @@ export const POST = withRouteHandler(async (request: NextRequest) => {
191191
headers['X-Disable-Provenance'] = 'true'
192192
}
193193

194-
const updateUrl = `${baseUrl}/api/v1/provisioning/alert-rules/${params.alertRuleUid}`
194+
const updateUrl = `${baseUrl}/api/v1/provisioning/alert-rules/${params.alertRuleUid.trim()}`
195195
const urlValidation = await validateUrlWithDNS(updateUrl, 'baseUrl')
196196
if (!urlValidation.isValid || !urlValidation.resolvedIP) {
197197
return NextResponse.json({

apps/sim/app/api/tools/grafana/update_dashboard/route.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export const POST = withRouteHandler(async (request: NextRequest) => {
6262
getHeaders['X-Grafana-Org-Id'] = params.organizationId
6363
}
6464

65-
const getUrl = `${baseUrl}/api/dashboards/uid/${params.dashboardUid}`
65+
const getUrl = `${baseUrl}/api/dashboards/uid/${params.dashboardUid.trim()}`
6666
const getValidation = await validateUrlWithDNS(getUrl, 'baseUrl')
6767
if (!getValidation.isValid || !getValidation.resolvedIP) {
6868
return NextResponse.json({

0 commit comments

Comments
 (0)