fix(enrichment): address PR review on Icypeas success + Datagma billing

- Icypeas find_email/verify_email postProcess return success:true for all
  terminal statuses (NOT_FOUND/DEBITED_NOT_FOUND included) so the cascade
  runner calls mapOutput and records invalid/not-found verdicts instead of
  throwing and inflating the error count
- Bill Icypeas verify FOUND (not just DEBITED*) per the documented 0.1-credit
  charge
- Datagma enrich_person only applies the 30-credit phone surcharge when a
  phone lookup (phoneFull) was requested
- Note Datagma's URL-param (apiId) auth in the hosted-key doc comment
- Update hosting tests to match

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: TheodoreSpeaks

apps/sim/tools/datagma-hosting.test.ts

@@ -55,16 +55,26 @@ describe('Datagma enrich person pricing', () => {
     ).toBeCloseTo(2 * DATAGMA_CREDIT_USD)
   })
 
-  it('charges 32 credits (2 + 30) when phone is also found', () => {
+  it('charges 32 credits (2 + 30) when a phone lookup was requested and found', () => {
     expect(
       cost(
         enrichPersonTool,
-        {},
+        { phoneFull: true },
         { name: 'John Doe', email: 'john@stripe.com', phone: '+14155551234' }
       ).cost
     ).toBeCloseTo(32 * DATAGMA_CREDIT_USD)
   })
 
+  it('does not charge the phone surcharge when phoneFull was not requested', () => {
+    expect(
+      cost(
+        enrichPersonTool,
+        {},
+        { name: 'John Doe', email: 'john@stripe.com', phone: '+14155551234' }
+      ).cost
+    ).toBeCloseTo(2 * DATAGMA_CREDIT_USD)
+  })
+
   it('charges 0 credits on no match', () => {
     expect(cost(enrichPersonTool, {}, { name: null, email: null }).cost).toBe(0)
     expect(cost(enrichPersonTool, {}, {}).cost).toBe(0)

apps/sim/tools/datagma/enrich_person.ts

@@ -22,7 +22,9 @@ export const enrichPersonTool: ToolConfig<DatagmaEnrichPersonParams, DatagmaEnri
       const name = output.name as string | null
       const email = output.email as string | null
       if (!name && !email) return 0
-      const phoneCredits = output.phone ? 30 : 0
+      // The 30-credit phone surcharge applies only when the caller requested a
+      // phone lookup (phoneFull); a phone that rides along otherwise isn't charged.
+      const phoneCredits = params.phoneFull && output.phone ? 30 : 0
       return 2 + phoneCredits
     }),
 

apps/sim/tools/datagma/hosting.ts

@@ -3,6 +3,11 @@ import type { ToolHostingConfig } from '@/tools/types'
 /**
  * Env var prefix for Datagma hosted keys. Provide keys as
  * `DATAGMA_API_KEY_COUNT` plus `DATAGMA_API_KEY_1..N`.
+ *
+ * Note: Datagma authenticates via an `apiId` URL query parameter (its only
+ * documented scheme), so the key appears verbatim in every request URL and may
+ * be captured by Datagma's and any intermediary's access logs. Treat a leaked
+ * key accordingly and rotate via the env vars above.
  */
 export const DATAGMA_API_KEY_PREFIX = 'DATAGMA_API_KEY'
 

apps/sim/tools/icypeas-hosting.test.ts

@@ -138,7 +138,7 @@ describe('Icypeas find-email postProcess poll', () => {
     expect((result.output as any).status).toBe('FOUND')
   })
 
-  it('returns success=false for NOT_FOUND terminal status', async () => {
+  it('returns success=true with a null email for NOT_FOUND terminal status', async () => {
     vi.useFakeTimers()
 
     const fetchMock = vi.fn().mockResolvedValue(
@@ -172,8 +172,9 @@ describe('Icypeas find-email postProcess poll', () => {
     await vi.advanceTimersByTimeAsync(3000)
     const result = await promise
 
-    expect(result.success).toBe(false)
+    expect(result.success).toBe(true)
     expect((result.output as any).status).toBe('NOT_FOUND')
+    expect((result.output as any).email).toBeNull()
   })
 })
 

apps/sim/tools/icypeas/find_email.ts

@@ -162,8 +162,12 @@ export const icypeasFindEmailTool: ToolConfig<IcypeasFindEmailParams, IcypeasFin
       const status = (item.status as string | undefined) ?? null
 
       if (status && TERMINAL_STATUSES.has(status)) {
+        // Any terminal status is a successful run — a clean no-match is not a
+        // failure. The enrichment cascade only calls mapOutput when success is
+        // true, so returning false would skip the verdict and inflate the
+        // runner's error count. A null email signals "not found" downstream.
         return {
-          success: FOUND_STATUSES.has(status),
+          success: true,
           output: mapItem(item),
         }
       }

apps/sim/tools/icypeas/verify_email.ts

@@ -58,16 +58,14 @@ export const icypeasVerifyEmailTool: ToolConfig<
   version: '1.0.0',
 
   hosting: icypeasHosting<IcypeasVerifyEmailParams>((_params, output) => {
-    // 0.1 credit per verification attempt that was processed (FOUND, DEBITED,
-    // or DEBITED_NOT_FOUND — any status containing "DEBITED" means credits were
-    // consumed). BAD_INPUT / INSUFFICIENT_FUNDS / ABORTED / NOT_FOUND indicate
-    // the search was not processed or charged.
+    // 0.1 credit per verification that consumed credits: FOUND/DEBITED (verdict
+    // delivered) and DEBITED_NOT_FOUND (debited even though unresolved).
+    // BAD_INPUT / INSUFFICIENT_FUNDS / ABORTED / NOT_FOUND are never charged.
     const status = output.status as string | undefined
     if (!status) {
       throw new Error('Icypeas verify-email: cannot determine cost — status is missing')
     }
-    // Billable when the status name contains DEBITED (i.e. DEBITED or DEBITED_NOT_FOUND).
-    const billable = status.includes('DEBITED')
+    const billable = status === 'FOUND' || status.includes('DEBITED')
     // 0.1 credit; express as a fractional number so ICYPEAS_CREDIT_USD math works.
     return billable ? 0.1 : 0
   }),
@@ -155,8 +153,12 @@ export const icypeasVerifyEmailTool: ToolConfig<
       const status = (item.status as string | undefined) ?? null
 
       if (status && TERMINAL_STATUSES.has(status)) {
+        // Any terminal status is a successful run — NOT_FOUND/DEBITED_NOT_FOUND are
+        // definitive verdicts, not failures. The enrichment cascade only calls
+        // mapOutput when success is true, so returning false here would skip those
+        // verdicts and inflate the runner's error count. `valid` carries the result.
         return {
-          success: VALID_STATUSES.has(status),
+          success: true,
           output: mapItem(item),
         }
       }