fix(kb): fix Linear connector GraphQL type errors and tag slot reuse

[waleedlatif1]

Summary

• Fix Linear connector 400 errors by changing GraphQL variable types from String! to ID! for team/project filter comparators and issue lookup
• Fix duplicate tag slot allocation when adding a second connector — reuse existing tag definitions that match by display name instead of allocating new slots

Type of Change

• Bug fix

Testing

Tested manually

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Apr 3, 2026 10:57pm

[cursor]

PR Summary

Medium Risk
Changes affect connector creation (tag definition persistence) and Linear GraphQL query construction, which could impact connector setup/sync behavior if slot reuse or ID typing is incorrect. Scope is limited to these flows and is primarily bug-fix oriented.

Overview
Fixes connector creation to reuse existing knowledge-base tag slots when a connector’s tag definition matches an existing displayName + fieldType, and only creates new tag definitions for newly allocated slots.

Updates the Linear connector’s GraphQL queries to use ID! (instead of String!) for issue lookup and team/project filter variables, addressing 400/type errors from Linear when filtering or fetching by id.

^{Reviewed by Cursor Bugbot for commit 6e0d016. Configure here.}

[greptile-apps]

Greptile Summary

This PR delivers two targeted bug fixes for the knowledge base connector system:

1. Linear GraphQL type fix: Changes variable types from String! to ID! for teamId, projectId, and issue id in all GraphQL query definitions. Linear's API schema defines these fields as the ID scalar, so using String! was causing 400 errors. The fix correctly aligns with Linear's schema.

2. Tag slot deduplication on connector creation: Adds a pre-allocation step in POST /api/knowledge/[id]/connectors that queries existing tag definitions for the knowledge base, builds a map by displayName, and reuses the existing slot when a new connector's tag definition matches by both displayName and fieldType. Only genuinely new definitions are forwarded to allocateTagSlots, and only those are written to the DB inside the transaction.

Key changes:

• apps/sim/connectors/linear/linear.ts: $id: String! → $id: ID! in ISSUE_BY_ID_QUERY; $teamId: String! → $teamId: ID! and $projectId: String! → $projectId: ID! in buildIssuesQuery
• apps/sim/app/api/knowledge/[id]/connectors/route.ts: Adds existingDefs query, existingByName map, and defsNeedingSlots filter before slot allocation; separates newTagSlots (DB writes) from tagSlotMapping (full mapping stored in config)

Confidence Score: 5/5

Safe to merge — both fixes are targeted, correct, and well-scoped with no regressions introduced

The Linear type change (String! → ID!) directly matches Linear's GraphQL schema and eliminates the 400 errors. The tag slot reuse logic correctly separates existing-slot reuse from new-slot allocation, only writing new knowledgeBaseTagDefinitions rows to the DB. The fieldType guard on reuse prevents mismatched slot types. No P0 or P1 findings; the PR is clean.

No files require special attention

Important Files Changed

Filename	Overview
apps/sim/connectors/linear/linear.ts	Correct fix: changes GraphQL variable types for teamId, projectId, and issue id from String! to ID! to match Linear's API schema and resolve 400 errors
apps/sim/app/api/knowledge/[id]/connectors/route.ts	Adds tag slot reuse logic that queries existing tag definitions and maps them by displayName+fieldType before allocation, correctly separating reused slots from new ones so duplicate DB entries are avoided when adding a second connector

Sequence Diagram

sequenceDiagram
    participant Client
    participant Route as POST /api/knowledge/[id]/connectors
    participant DB
    participant Linear as Linear GraphQL API

    Client->>Route: POST with connectorType, credentialId, sourceConfig
    Route->>DB: Query existing knowledgeBaseTagDefinitions
    DB-->>Route: existingDefs (tagSlot, displayName, fieldType)
    Note over Route: Build existingByName map<br/>Separate reused vs new defs
    Route->>Route: allocateTagSlots(defsNeedingSlots, usedSlots)
    Route->>DB: BEGIN TRANSACTION, LOCK knowledge_base row
    Route->>DB: createTagDefinition (new slots only)
    Route->>DB: INSERT knowledgeConnector (with full tagSlotMapping)
    DB-->>Route: OK
    Route->>Route: dispatchSync(connectorId)
    Route-->>Client: 201 Created

    Note over Linear: During sync
    Route->>Linear: ListIssues ($teamId: ID!, $projectId: ID!)
    Linear-->>Route: Issues page
    Route->>Linear: GetIssue ($id: ID!)
    Linear-->>Route: Issue detail

Loading

_{Reviews (2): Last reviewed commit: "fix(kb): verify field type when reusing ..." | Re-trigger Greptile}

[waleedlatif1]

@greptile

[waleedlatif1]

@cursor review

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 6e0d016. Configure here.}